Ubuntu Clock App

Merge lp:~phillip-sz/ubuntu-clock-app/remove-wrong-char into lp:ubuntu-clock-app

  1. remove-wrong-char
  2. Merge into trunk
Proposed by Phillip Sz
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 212
Merged at revision: 212
Proposed branch: lp:~phillip-sz/ubuntu-clock-app/remove-wrong-char
Merge into: lp:ubuntu-clock-app
Diff against target: 12 lines (+1/-1)
1 file modified
backend/modules/Timezone/statictimezonemodel.cpp (+1/-1)
To merge this branch: bzr merge lp:~phillip-sz/ubuntu-clock-app/remove-wrong-char
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nekhelesh Ramananthan Approve
Review via email: mp+252204@code.launchpad.net

Commit message

remove wrong "’" in city name

Description of the change

remove wrong "’" in city name:

"Simferopol’" is not the name its "Simferopol"

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Ah man I can't believe there were typos like these...previously I wrote "Librya" instead of Libya..Thnx for spotting it and for the fix.

review: Approve
Revision history for this message
Phillip Sz (phillip-sz) wrote :

thanks a lot! I discovered while translating :)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

@Phillip, I just noticed in this MP that the pot file was not updated to include the new translation. I missed that during my review, sry. I fixed this issue in https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-translation-plural-forms/+merge/252838 which should get merged today.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'backend/modules/Timezone/statictimezonemodel.cpp'
2--- backend/modules/Timezone/statictimezonemodel.cpp 2015-03-06 10:54:21 +0000
3+++ backend/modules/Timezone/statictimezonemodel.cpp 2015-03-07 13:13:47 +0000
4@@ -303,7 +303,7 @@
5 addCity(_("Seoul"), "Asia/Seoul", _("South Korea"));
6 addCity(_("Shanghai"), "Asia/Shanghai", _("China"));
7 addCity(_("Singapore"), "Asia/Singapore", _("Singapore"));
8- addCity(_("Simferopol’"), "Europe/Simferopol", _("Ukraine"));
9+ addCity(_("Simferopol"), "Europe/Simferopol", _("Ukraine"));
10 addCity(_("Skopje"), "Europe/Skopje", _("Macedonia"));
11 addCity(_("Sofia"), "Europe/Sofia", _("Bulgaria"));
12 addCity(_("St.Johns"), "America/St_Johns", _("Canada"));

Subscribers

People subscribed via source and target branches