Code review comment for lp:~phill-ridout/openlp/saved_bible_verses

Revision history for this message
Tomas Groth (tomasgroth) wrote :

I just did a quick test, where I using ESV:
 * Searched for "wrath", saved the verses.
 * Searched for "wrath of" and again saved the verses.

This causes the a lot of duplicates in the saved verse lists since the second list of saved verses seems to be appended to the existing list, without any duplicate checks. Is this intended behavior? Maybe removing duplicates and inserting new saved verses into list so that they are chronologically ordered, should be considered?

« Back to merge proposal