Merge lp:~philipballew/ubuntu-community-accomplishments/ubuntu-youth-council into lp:ubuntu-community-accomplishments

[philipballew]

I changed some Ubuntu Youth council stuff for you!

[Rafał Cieślak (rafalcieslak256)]

Awesome work, huge thanks.
There is one more tiny thing that will need fixing: The accomplishment icon has white background (instead of transparent) which causes it to look oddly in notification bubbles and viewer's trophy list. Can you please fix it? ;-)

review: Needs Fixing

[lp:~philipballew/ubuntu-community-accomplishments/ubuntu-youth-council]

218. By philipballew on 2012-08-11

added better ubuntu-youth image

219. By philipballew on 2012-08-11

added better ubuntu-youth image and changed accomplishment file to match

[Jono Bacon (jonobacon)]

Is this now ready for review again, Phillip?

review: Needs Information

[philipballew (philipballew)]

Yes. I have made the corrections I was instructed to to. If there is
anything else needed feel free to let me know and I'll get on making
those as well.

On Mon, Aug 13, 2012 at 7:19 PM, Jono Bacon <email address hidden> wrote:
> Review: Needs Information
>
> Is this now ready for review again, Phillip?
> --
> https://code.launchpad.net/~philipballew/ubuntu-community-accomplishments/ubuntu-youth-council/+merge/119073
> You are the owner of lp:~philipballew/ubuntu-community-accomplishments/ubuntu-youth-council.

[Jono Bacon (jonobacon)]

Thanks, Philip for your contribution!

Just a few small changes needed:

 * Please flesh out the summary - explain what the youth team is, its goals, who can join etc. Always assume the reader has no idea about the team in question. :-)
 * Could you flesh out to the steps to include details of how someone would apply to be on the council. See the Community Council accom as an example of the steps fleshed out.
 * Please set the category to Governance.
 * There are a few typos in there, please make sure you run the text through a spell checker.

Other than these small changes, this is ready to go! :-)

review: Needs Fixing

[Matt Fischer (mfisch)]

Any updates on this? I can merge it in once it's all ready.

[lp:~philipballew/ubuntu-community-accomplishments/ubuntu-youth-council]

220. By philipballew on 2012-12-23

fixed

[Matt Fischer (mfisch)]

I think it looks good. I'm going to switch the depends to being a member of the ubuntu-youth team since it's a closer pre-req. Next time you should probably run spell check on this to catch some of the typos. Thanks for contributing it!

review: Approve

=== added file 'accomplishments/ubuntu-community/en/governance/ubuntu-youth-council.accomplishment'
--- accomplishments/ubuntu-community/en/governance/ubuntu-youth-council.accomplishment	1970-01-01 00:00:00 +0000
+++ accomplishments/ubuntu-community/en/governance/ubuntu-youth-council.accomplishment	2012-12-23 03:00:29 +0000
@@ -0,0 +1,15 @@
+[accomplishment]
+title=Approved Ubuntu Youth Council Member
+description=You are an Approved Ubuntu Youth Council Member
+collection=ubuntu-community
+category=Governance
+needs-signing=true
+depends=ubuntu-community/registered-on-launchpad
+icon=ubuntu-youth.png
+needs-information=launchpad-email
+summary = Someone who is part of the Ubuntu Youth Council is somebody who has spent a great deal of time helping to contribute to the Ubuntu Youth project and was able to win an elcetion from other members of Ubuntu Youth that shows they had the acility to help lead Ubuntu Youth. all indivuidals of the Ubuntu Youth Council will have to attend regualar meetengs and be able to activitly partisibate in the decisions regarding the Ubuntu Youth team.  
+steps: Join the Ubuntu Youth team and contribute untill the next Ubuntu Youth Council election. When a call for namanations come out, nominate yourself and see if you win
+tips: Be sure to be positive and get to know everyone in the Ubuntu youth group.
+links: https://launchpad.net/~ubuntu-youth-council
+help = #ubuntu-youth-council on Freenode
+author = Philip Ballew <[e-mail]>

=== added file 'accomplishments/ubuntu-community/trophyimages/ubuntu-youth.png'
Binary files accomplishments/ubuntu-community/trophyimages/ubuntu-youth.png	1970-01-01 00:00:00 +0000 and accomplishments/ubuntu-community/trophyimages/ubuntu-youth.png	2012-12-23 03:00:29 +0000 differ
=== added file 'scripts/ubuntu-community/governance/ubuntu-youth-council.py'
--- scripts/ubuntu-community/governance/ubuntu-youth-council.py	1970-01-01 00:00:00 +0000
+++ scripts/ubuntu-community/governance/ubuntu-youth-council.py	2012-12-23 03:00:29 +0000
@@ -0,0 +1,28 @@
+#!/usr/bin/python
+import traceback, sys
+
+from accomplishments.daemon import dbusapi
+# Add scripts/lib/ to the PYTHONPATH
+import os
+sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), '..', 'lib')))
+from helpers import Launchpad
+
+try:
+    api = dbusapi.Accomplishments()
+    f = api.get_extra_information("ubuntu-community", "launchpad-email")
+    if bool(f[0]["launchpad-email"]) == False:
+        sys.exit(4)
+    else:
+        email = f[0]["launchpad-email"]
+        
+    me = Launchpad.fetch(email)
+    if "ubuntu-youth-council" in me.super_teams:
+        sys.exit(0)
+    else:
+        sys.exit(1)
+
+except SystemExit, e:
+    sys.exit(e.code)
+except:
+    traceback.print_exc()
+    sys.exit(2)

=== added file 'tests/ubuntu-community/governance/ubuntu-youth-council'
--- tests/ubuntu-community/governance/ubuntu-youth-council	1970-01-01 00:00:00 +0000
+++ tests/ubuntu-community/governance/ubuntu-youth-council	2012-12-23 03:00:29 +0000
@@ -0,0 +1,5 @@
+[success]
+launchpad-email = [e-mail]
+
+[failure]
+launchpad-email = [e-mail]