Merge lp:~philip.scott/wingpanel/touch-closing-fix into lp:~wingpanel-devs/wingpanel/trunk

Proposed by Felipe Escoto
Status: Merged
Approved by: Danielle Foré
Approved revision: 168
Merged at revision: 168
Proposed branch: lp:~philip.scott/wingpanel/touch-closing-fix
Merge into: lp:~wingpanel-devs/wingpanel/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
src/Services/PopoverManager.vala (+1/-1)
To merge this branch: bzr merge lp:~philip.scott/wingpanel/touch-closing-fix
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+316392@code.launchpad.net

Commit message

Prevent switching indicators with touchscreen from closing

Description of the change

When taping another indicator after opening one with a touch screen, the indicator chosen would quickly open and close. This was due to the fact that when you tapped, the cursor was "moved" to that location (it triggered the change as if you moved the cursor around) AND also got the button tapped event (the actual click)

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I can confirm that this branch fixes the behavior for touch and doesn't appear to cause any regressions for mouse input :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Services/PopoverManager.vala'
2--- src/Services/PopoverManager.vala 2017-01-02 21:30:08 +0000
3+++ src/Services/PopoverManager.vala 2017-02-04 20:59:39 +0000
4@@ -178,7 +178,7 @@
5 }
6
7 if (grabbed) {
8- if (!get_visible (widg)) {
9+ if (!get_visible (widg) && e.mode != Gdk.CrossingMode.TOUCH_BEGIN) {
10 mousing = true;
11 current_indicator = widg;
12 mousing = false;

Subscribers

People subscribed via source and target branches

to all changes: