Merge lp:~philip.scott/wingpanel-indicator-sound/wingpanel-indicator-sound into lp:~wingpanel-devs/wingpanel-indicator-sound/trunk
Proposed by
Felipe Escoto
Status: | Merged |
---|---|
Approved by: | Djax |
Approved revision: | 24 |
Merged at revision: | 23 |
Proposed branch: | lp:~philip.scott/wingpanel-indicator-sound/wingpanel-indicator-sound |
Merge into: | lp:~wingpanel-devs/wingpanel-indicator-sound/trunk |
Diff against target: |
63 lines (+12/-5) 1 file modified
src/Indicator.vala (+12/-5) |
To merge this branch: | bzr merge lp:~philip.scott/wingpanel-indicator-sound/wingpanel-indicator-sound |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
kay van der Zander | Needs Fixing | ||
Review via email: mp+263009@code.launchpad.net |
Description of the change
Makes sure the sound confirmation is closed whenever the sound indicator's popover is opened.
* If the confirmation was opened, close it when the popover appears
* If the popover is opened, do not show a notification when you scroll on the icon
It does not fix: https:/
A small change with how the settings panel opens also slipped by, before if you open the sound settings from the indicator, you sometimes couldn't interact with the sound indicator until you closed switchboard. But this is fixed on this merge by closing the indicator before opening switchboard
To post a comment you must log in.
Hey please improve:
Dif line 16 17 remove space behind bracket
Dif line 34 35 remove space behind bracket
Dif line 49 do something with the error information