Merge lp:~philip.scott/wingpanel-indicator-session/init-whats-needed into lp:~wingpanel-devs/wingpanel-indicator-session/trunk

Proposed by Felipe Escoto
Status: Merged
Approved by: Danielle Foré
Approved revision: 85
Merged at revision: 85
Proposed branch: lp:~philip.scott/wingpanel-indicator-session/init-whats-needed
Merge into: lp:~wingpanel-devs/wingpanel-indicator-session/trunk
Diff against target: 53 lines (+18/-13)
2 files modified
src/Indicator.vala (+13/-11)
src/Widgets/EndSessionDialog.vala (+5/-2)
To merge this branch: bzr merge lp:~philip.scott/wingpanel-indicator-session/init-whats-needed
Reviewer Review Type Date Requested Status
WingPanel Devs Pending
Review via email: mp+299843@code.launchpad.net

Commit message

Prevent unneeded interfaces from timing out

Description of the change

The reason it was taking too long to start up the Shutdown dialog in greeter it was because we were starting up the session interface even when we weren't in a session, thus it was timing out...

This branch should fix it as it now only starts up the needed interfaces

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Indicator.vala'
2--- src/Indicator.vala 2016-05-21 15:56:59 +0000
3+++ src/Indicator.vala 2016-07-12 16:36:50 +0000
4@@ -100,18 +100,20 @@
5 suspend.set_sensitive (false);
6 }
7
8- try {
9- lock_interface = Bus.get_proxy_sync (BusType.SESSION, "org.freedesktop.ScreenSaver", "/org/freedesktop/ScreenSaver");
10- } catch (IOError e) {
11- stderr.printf ("%s\n", e.message);
12- lock_screen.set_sensitive (false);
13- }
14+ if (server_type == Wingpanel.IndicatorManager.ServerType.SESSION) {
15+ try {
16+ lock_interface = Bus.get_proxy_sync (BusType.SESSION, "org.freedesktop.ScreenSaver", "/org/freedesktop/ScreenSaver");
17+ } catch (IOError e) {
18+ stderr.printf ("%s\n", e.message);
19+ lock_screen.set_sensitive (false);
20+ }
21
22- try {
23- seat_interface = Bus.get_proxy_sync (BusType.SESSION, "org.freedesktop.DisplayManager", "/org/freedesktop/DisplayManager/Seat0");
24- } catch (IOError e) {
25- stderr.printf ("%s\n", e.message);
26- lock_screen.set_sensitive (false);
27+ try {
28+ seat_interface = Bus.get_proxy_sync (BusType.SESSION, "org.freedesktop.DisplayManager", "/org/freedesktop/DisplayManager/Seat0");
29+ } catch (IOError e) {
30+ stderr.printf ("%s\n", e.message);
31+ lock_screen.set_sensitive (false);
32+ }
33 }
34 }
35
36
37=== modified file 'src/Widgets/EndSessionDialog.vala'
38--- src/Widgets/EndSessionDialog.vala 2016-01-15 19:59:37 +0000
39+++ src/Widgets/EndSessionDialog.vala 2016-07-12 16:36:50 +0000
40@@ -39,8 +39,11 @@
41
42 construct {
43 try {
44- session_interface = Bus.get_proxy_sync (BusType.SESSION, "org.gnome.SessionManager", "/org/gnome/SessionManager");
45- system_interface = Bus.get_proxy_sync (BusType.SYSTEM, "org.freedesktop.login1", "/org/freedesktop/login1");
46+ if (dialog_type == Session.Widgets.EndSessionDialogType.LOGOUT) {
47+ session_interface = Bus.get_proxy_sync (BusType.SESSION, "org.gnome.SessionManager", "/org/gnome/SessionManager");
48+ } else {
49+ system_interface = Bus.get_proxy_sync (BusType.SYSTEM, "org.freedesktop.login1", "/org/freedesktop/login1");
50+ }
51 } catch (IOError e) {
52 stderr.printf ("%s\n", e.message);
53 }

Subscribers

People subscribed via source and target branches

to all changes: