Merge lp:~philip.scott/wingpanel-indicator-network/captive-login into lp:~wingpanel-devs/wingpanel-indicator-network/trunk

Proposed by Felipe Escoto
Status: Merged
Approved by: Danielle Foré
Approved revision: 143
Merged at revision: 146
Proposed branch: lp:~philip.scott/wingpanel-indicator-network/captive-login
Merge into: lp:~wingpanel-devs/wingpanel-indicator-network/trunk
Diff against target: 45 lines (+21/-0)
1 file modified
src/Indicator.vala (+21/-0)
To merge this branch: bzr merge lp:~philip.scott/wingpanel-indicator-network/captive-login
Reviewer Review Type Date Requested Status
WingPanel Devs Pending
Review via email: mp+292457@code.launchpad.net

Commit message

run captive-login on network connect

Description of the change

Since the captive portal depended on nm-applet, this branch makes it run after it connects to a network.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Indicator.vala'
2--- src/Indicator.vala 2015-07-13 17:16:52 +0000
3+++ src/Indicator.vala 2016-04-21 00:32:53 +0000
4@@ -20,6 +20,9 @@
5
6 Network.Widgets.PopoverWidget? popover_widget = null;
7
8+ NetworkMonitor network_monitor;
9+ bool captive_started = false;
10+
11 public Indicator () {
12 Object (code_name: Wingpanel.Indicator.NETWORK,
13 display_name: _("Network"),
14@@ -45,6 +48,7 @@
15 popover_widget.settings_shown.connect (() => { close (); });
16
17 on_state_changed ();
18+ start_monitor ();
19 }
20
21 return popover_widget;
22@@ -57,6 +61,23 @@
23 display_widget.update_state (popover_widget.state);
24 }
25
26+ private void start_monitor () {
27+ network_monitor = NetworkMonitor.get_default ();
28+
29+ network_monitor.network_changed.connect ((availabe) => {
30+ if (!captive_started) {
31+ if (network_monitor.get_connectivity () == NetworkConnectivity.FULL || network_monitor.get_connectivity () == NetworkConnectivity.PORTAL) {
32+ var command = new Granite.Services.SimpleCommand ("/usr/bin/", "captive-login");
33+ command.done.connect (() => { captive_started = false; });
34+
35+ captive_started = true;
36+
37+ command.run ();
38+ }
39+ }
40+ });
41+ }
42+
43 public override void opened () {
44 // TODO
45 }

Subscribers

People subscribed via source and target branches

to all changes: