Merge lp:~philip.scott/switchboard-plug-notifications/other-to-bottom into lp:~elementary-pantheon/switchboard-plug-notifications/trunk

Proposed by Felipe Escoto
Status: Merged
Approved by: Cody Garver
Approved revision: 174
Merged at revision: 178
Proposed branch: lp:~philip.scott/switchboard-plug-notifications/other-to-bottom
Merge into: lp:~elementary-pantheon/switchboard-plug-notifications/trunk
Diff against target: 32 lines (+9/-1)
1 file modified
src/Widgets/AppList.vala (+9/-1)
To merge this branch: bzr merge lp:~philip.scott/switchboard-plug-notifications/other-to-bottom
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Fixing
Review via email: mp+298994@code.launchpad.net

Commit message

AppList: Push gala-other.desktop to the bottom

Description of the change

Depends on: https://code.launchpad.net/~philip.scott/gala/notifications-app-ids/+merge/298930

Makes the Other app entry appear at the bottom

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

Rename other.desktop to gala-other.desktop

review: Needs Fixing
174. By Felipe Escoto

AppList: Push other.desktop to the bottom

Revision history for this message
Felipe Escoto (philip.scott) wrote :

Updated the .desktop name. Now all we need is for Rico to approve the Gala branch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/AppList.vala'
2--- src/Widgets/AppList.vala 2015-10-11 11:46:15 +0000
3+++ src/Widgets/AppList.vala 2016-07-11 16:06:34 +0000
4@@ -18,6 +18,8 @@
5 */
6
7 public class Widgets.AppList : Gtk.ListBox {
8+ private const string FALLBACK_APP_ID = "gala-other.desktop";
9+
10 construct {
11 this.selection_mode = Gtk.SelectionMode.SINGLE;
12 this.set_sort_func (sort_func);
13@@ -68,6 +70,12 @@
14 return 0;
15 }
16
17+ if (((AppEntry)row1).app.app_info.get_id () == FALLBACK_APP_ID) {
18+ return 1;
19+ } else if (((AppEntry)row2).app.app_info.get_id () == FALLBACK_APP_ID) {
20+ return -1;
21+ }
22+
23 string row_name1 = ((AppEntry)row1).app.app_info.get_display_name ();
24 string row_name2 = ((AppEntry)row2).app.app_info.get_display_name ();
25
26@@ -75,4 +83,4 @@
27
28 return order.clamp (-1, 1);
29 }
30-}
31\ No newline at end of file
32+}

Subscribers

People subscribed via source and target branches

to all changes: