Merge lp:~philip.scott/switchboard-plug-a11y/enable-animations into lp:~elementary-pantheon/switchboard-plug-a11y/trunk

Proposed by Felipe Escoto
Status: Merged
Approved by: Danielle Foré
Approved revision: 68
Merged at revision: 68
Proposed branch: lp:~philip.scott/switchboard-plug-a11y/enable-animations
Merge into: lp:~elementary-pantheon/switchboard-plug-a11y/trunk
Diff against target: 87 lines (+20/-7)
4 files modified
src/Backend/Settings.vala (+8/-0)
src/Panes/General.vala (+9/-6)
src/Plug.vala (+2/-0)
src/Widgets/Categories.vala (+1/-1)
To merge this branch: bzr merge lp:~philip.scott/switchboard-plug-a11y/enable-animations
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+297563@code.launchpad.net

Commit message

Disable animations switch

Description of the change

Enable/disable animations switch

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Backend/Settings.vala'
2--- src/Backend/Settings.vala 2015-09-03 01:41:51 +0000
3+++ src/Backend/Settings.vala 2016-06-15 22:08:02 +0000
4@@ -246,3 +246,11 @@
5 base ("org.gnome.desktop.a11y.mouse");
6 }
7 }
8+
9+public class Accessibility.Backend.Animations : Granite.Services.Settings {
10+ public bool enable_animations { get; set; }
11+
12+ public Animations () {
13+ base ("org.pantheon.desktop.gala.animations");
14+ }
15+}
16
17=== modified file 'src/Panes/General.vala'
18--- src/Panes/General.vala 2015-11-27 15:54:08 +0000
19+++ src/Panes/General.vala 2016-06-15 22:08:02 +0000
20@@ -20,8 +20,9 @@
21 * Authored by: Felipe Escoto <felescoto95@hotmail.com>
22 */
23 public class Accessibility.Panes.General : Categories.Pane {
24- private Gtk.Switch keyboard;
25- private Gtk.Switch panel;
26+ //private Gtk.Switch keyboard;
27+ //private Gtk.Switch panel;
28+ private Gtk.Switch animations;
29
30 public General () {
31 base (_("General"), "preferences-desktop-accessibility");
32@@ -34,8 +35,9 @@
33
34 private void build_ui () {
35 var general = new Accessibility.Widgets.SettingsBox ();
36- keyboard = general.add_switch (_("Turn accessibility features on and off using the keyboard:"));
37- panel = general.add_switch (_("Display accessibility menu in panel:"));
38+ //keyboard = general.add_switch (_("Turn accessibility features on and off using the keyboard:"));
39+ //panel = general.add_switch (_("Display accessibility menu in panel:"));
40+ animations = general.add_switch (_("Animations"));
41
42 grid.add (general);
43
44@@ -43,7 +45,8 @@
45 }
46
47 private void connect_signals () {
48- keyboard_settings.schema.bind ("enable", keyboard, "active", SettingsBindFlags.DEFAULT);
49- a11y_settings.schema.bind ("always-show-universal-access-status", panel, "active", SettingsBindFlags.DEFAULT);
50+ //keyboard_settings.schema.bind ("enable", keyboard, "active", SettingsBindFlags.DEFAULT);
51+ //a11y_settings.schema.bind ("always-show-universal-access-status", panel, "active", SettingsBindFlags.DEFAULT);
52+ animations_settings.schema.bind ("enable-animations", animations, "active", SettingsBindFlags.DEFAULT);
53 }
54 }
55
56=== modified file 'src/Plug.vala'
57--- src/Plug.vala 2016-04-25 11:59:24 +0000
58+++ src/Plug.vala 2016-06-15 22:08:02 +0000
59@@ -31,6 +31,7 @@
60 public Accessibility.Backend.Peripherals peripherals_settings;
61 public Accessibility.Backend.Mouse mouse_settings;
62 public Accessibility.Backend.MediaKeys media_keys_settings;
63+ public Accessibility.Backend.Animations animations_settings;
64
65 public class Plug : Switchboard.Plug {
66 Gtk.Paned paned;
67@@ -54,6 +55,7 @@
68 peripherals_settings = new Accessibility.Backend.Peripherals ();
69 mouse_settings = new Accessibility.Backend.Mouse ();
70 media_keys_settings = new Accessibility.Backend.MediaKeys ();
71+ animations_settings = new Accessibility.Backend.Animations ();
72 }
73
74 public override Gtk.Widget get_widget () {
75
76=== modified file 'src/Widgets/Categories.vala'
77--- src/Widgets/Categories.vala 2016-04-15 19:13:14 +0000
78+++ src/Widgets/Categories.vala 2016-06-15 22:08:02 +0000
79@@ -35,7 +35,7 @@
80 add (list_box);
81
82 var general = new Panes.General ();
83- //list_box.add (general); FIXME: These options currently do nothing
84+ list_box.add (general);
85
86 var display = new Panes.Display ();
87 list_box.add (display);

Subscribers

People subscribed via source and target branches

to all changes: