Photos

Merge lp:~philip.scott/pantheon-photos/editable-focus-out-behaviour into lp:~pantheon-photos/pantheon-photos/trunk

  1. editable-focus-out-behaviour
  2. Merge into trunk
Proposed by Felipe Escoto
Status: Merged
Approved by: Danielle Foré
Approved revision: 3057
Merged at revision: 3057
Proposed branch: lp:~philip.scott/pantheon-photos/editable-focus-out-behaviour
Merge into: lp:~pantheon-photos/pantheon-photos/trunk
Diff against target: 15 lines (+5/-0)
1 file modified
src/sidebar/EditableTitle.vala (+5/-0)
To merge this branch: bzr merge lp:~philip.scott/pantheon-photos/editable-focus-out-behaviour
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+311099@code.launchpad.net

Commit message

EditableTitle: Stop editing on focus out

Description of the change

You win Dan

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Yay :D

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/sidebar/EditableTitle.vala'
2--- src/sidebar/EditableTitle.vala 2016-11-06 18:21:29 +0000
3+++ src/sidebar/EditableTitle.vala 2016-11-17 02:47:17 +0000
4@@ -117,6 +117,11 @@
5 editing = false;
6 });
7
8+ entry.focus_out_event.connect ((event) => {
9+ editing = false;
10+ return false;
11+ });
12+
13 entry.icon_release.connect ((p0, p1) => {
14 if (p0 == Gtk.EntryIconPosition.SECONDARY) {
15 editing = false;

Subscribers

People subscribed via source and target branches

to all changes: