Merge lp:~philip.scott/granite/notifications-demo into lp:~elementary-pantheon/granite/granite
Proposed by
Felipe Escoto
Status: | Rejected |
---|---|
Rejected by: | Zisu Andrei |
Proposed branch: | lp:~philip.scott/granite/notifications-demo |
Merge into: | lp:~elementary-pantheon/granite/granite |
Diff against target: |
80 lines (+38/-1) 2 files modified
demo/CMakeLists.txt (+1/-1) demo/GraniteDemo.vala (+37/-0) |
To merge this branch: | bzr merge lp:~philip.scott/granite/notifications-demo |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Bieńkowski (community) | code / testing | Needs Fixing | |
Review via email: mp+297848@code.launchpad.net |
Commit message
Notification Demo Added
Description of the change
Adds a notifications demo to Granite Demo.
It also updates it's .desktop to use the correct name.
Note: The notifications sent from the Demo have no icon set manually, this is intended as the Gala branch that fixes this will land soon
To post a comment you must log in.
Unmerged revisions
- 951. By Felipe Escoto
-
Notifications Demo
It looks & works great, but following recent changes we should have "X-GNOME- UsesNotificatio ns=true" in the .desktop file to fully support the app settings. Also I'm not sure if we want to showcase non-granite feature in a granite-demo app, notice how all widgets & functions there are granite specific.