Code review comment for lp:~philip.scott/granite/editable-title

Revision history for this message
Adam Bieńkowski (donadigo) wrote :

* Use construct {} method of constructing the object.
* Use "construct set" for text property.
* There's no way of determining if the user is currently editing the label or not
* changed signal could probably have an additional parameter for something like "previous_title".
* Hm, reading the code it seems that every press on the widget will cause the editing to procced, maybe check if it's left click? Or is that intentional?

review: Needs Fixing (code)

« Back to merge proposal