Merge lp:~philip.scott/gala/workspace-thumb-align-icon-correctly into lp:gala

Proposed by Felipe Escoto
Status: Needs review
Proposed branch: lp:~philip.scott/gala/workspace-thumb-align-icon-correctly
Merge into: lp:gala
Diff against target: 11 lines (+1/-0)
1 file modified
src/Widgets/WorkspaceInsertThumb.vala (+1/-0)
To merge this branch: bzr merge lp:~philip.scott/gala/workspace-thumb-align-icon-correctly
Reviewer Review Type Date Requested Status
Danielle Foré testing Approve
Review via email: mp+319013@code.launchpad.net

Description of the change

Aligns the icon used to show which window will be inserted in a workspace correctly.

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I can confirm that this centers the icon in HiDPI :)

review: Approve (testing)
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Hmm, this doesn't make much sense. Doing so is very likely just luck that the visual result looks correct.

Unmerged revisions

568. By Felipe Escoto

WorkspaceInsertThumb: Align icon correctly

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/WorkspaceInsertThumb.vala'
2--- src/Widgets/WorkspaceInsertThumb.vala 2015-11-11 19:00:26 +0000
3+++ src/Widgets/WorkspaceInsertThumb.vala 2017-03-06 01:29:48 +0000
4@@ -65,6 +65,7 @@
5 destroy_all_children ();
6
7 var icon = new WindowIcon (window, IconGroupContainer.GROUP_WIDTH);
8+ icon.x = IconGroupContainer.SPACING;
9 icon.x_align = ActorAlign.CENTER;
10 add_child (icon);
11 }

Subscribers

People subscribed via source and target branches