Merge lp:~philip.scott/gala/notification-crash-fix into lp:gala

Proposed by Felipe Escoto on 2017-02-20
Status: Merged
Merged at revision: 567
Proposed branch: lp:~philip.scott/gala/notification-crash-fix
Merge into: lp:gala
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/notify/NotifyServer.vala (+1/-1)
To merge this branch: bzr merge lp:~philip.scott/gala/notification-crash-fix
Reviewer Review Type Date Requested Status
Rico Tzschichholz 2017-02-20 Approve on 2017-02-20
Review via email: mp+317734@code.launchpad.net

Commit message

Prevent crashing from .desktop files with an empty exec line

Description of the change

This prevents gala from crashing when it reads an empty exec line on a .desktop

To post a comment you must log in.
Rico Tzschichholz (ricotz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/notify/NotifyServer.vala'
2--- plugins/notify/NotifyServer.vala 2016-12-31 08:08:58 +0000
3+++ plugins/notify/NotifyServer.vala 2017-02-20 01:39:27 +0000
4@@ -637,7 +637,7 @@
5
6 return (app_name.down () == token
7 || token_executable == app_executable
8- || args[0] == token
9+ || (args.length > 0 && args[0] == token)
10 || app_display_name.down ().contains (token));
11 }
12 }

Subscribers

People subscribed via source and target branches