Merge lp:~philip.scott/audience/broken-window-fix into lp:~audience-members/audience/trunk

[Felipe Escoto]

Don't go to fullscreen when maximized to prevent gala bug

Workaround to gala's bug

=== modified file 'src/Window.vala'
--- src/Window.vala	2016-07-30 17:06:42 +0000
+++ src/Window.vala	2016-08-08 17:58:47 +0000
@@ -93,6 +93,24 @@
             }
             return false;
         });
+
+        window_state_event.connect ((e) => {
+            if (Gdk.WindowState.FULLSCREEN in e.changed_mask) {
+                player_page.fullscreened = Gdk.WindowState.FULLSCREEN in e.new_window_state;
+                header.visible = !player_page.fullscreened;
+            }
+
+            /*/ FIXME: Remove comments once gala bug is fixed: https://bugs.launchpad.net/gala/+bug/1602722
+            if (Gdk.WindowState.MAXIMIZED in e.changed_mask) {
+                bool currently_maximixed = Gdk.WindowState.MAXIMIZED in e.new_window_state;
+                
+                if (main_stack.get_visible_child () == player_page && currently_maximixed) {
+                   fullscreen (); 
+                }
+            }*/
+
+            return false;
+        });
     }
 
     /** Returns true if the code parameter matches the keycode of the keyval parameter for
@@ -203,22 +221,6 @@
         return false;
     }
 
-    public override bool window_state_event (Gdk.EventWindowState e) {
-        if (Gdk.WindowState.FULLSCREEN in e.changed_mask) {
-            player_page.fullscreened = Gdk.WindowState.FULLSCREEN in e.new_window_state;
-            header.visible = !player_page.fullscreened;
-        }
-
-        if (Gdk.WindowState.MAXIMIZED in e.changed_mask) {
-            bool currently_maximixed = Gdk.WindowState.MAXIMIZED in e.new_window_state;
-            if (main_stack.get_visible_child () == player_page && currently_maximixed) {
-                fullscreen ();
-            }
-        }
-
-        return false;
-    }
-
     public void open_files (File[] files, bool clear_playlist = false, bool force_play = true) {
         if (clear_playlist) {
             player_page.get_playlist_widget ().clear_items ();