Merge lp:~pharmasolin/ubuntu-manual-tests/VLC_updated into lp:ubuntu-manual-tests

[Lysenko Denis]

https://bugs.launchpad.net/ubuntu-manual-tests/+bug/1187485 don't know how much of testing should cover testcase, so updated with few more "basic" functional testing. If needed deeper testcase with creating play-lists and saving it, opening online streams for example, youtube videos etc, write me.

[Kev Bowring (flocculant)]

some inline comments

Also - can you add this to the very beginning of the testcase

<em>Testcase requires use of video and/or audio files</em>

thanks :)

review: Needs Fixing

[lp:~pharmasolin/ubuntu-manual-tests/VLC_updated]

344. By Lysenko Denis on 2015-10-26

Updated testcase for Orca (bug #1161570)

345. By Lysenko Denis on 2015-10-26

Fixing for VLC testcase

[Lysenko Denis (pharmasolin)]

Added fixes to VLC testcase, also Orca testcase updated.

[Kev Bowring (flocculant)]

re Orca.

I'm not too happy atm with it being Ubuntu-centric.

Testcases need to be written so they can be run from any of the official flavours as well as main Ubuntu.

No other DE has hud/unity/global menu.

Super in Xubuntu does nothing for example.

review: Needs Fixing

[Lysenko Denis (pharmasolin)]

In bug #1161570 it is said "The orca testcase needs to be verified and updated to reflect the accessibility changes that have happened in unity." So how to deal with it? I think we need testcases for different DE in this case, how to test that Orca can "understand" and can "tell" me what i'm focusing with Alt + F1 in Unity DE?

I think that solution can be mention in the test section where Unity is needed as for VLC

<em>Unity DE needed for this test</em>

[Kev Bowring (flocculant)]

changed the bug to be agnostic.

No - we don't need 5 different testcases to suit different DE's.

"how to test that Orca can "understand" and can "tell" me what i'm focusing with Alt + F1 in Unity DE?" run them from a VM maybe?

to be honest you'd in future be better off doing seperate MPs for different testcases - can't approve this until the orca one gets fixed, which means the work you did on vlc is now hanging about :)

review: Needs Fixing

[Lysenko Denis (pharmasolin)]

It is not a problem, so solution should be remove Unity DE specific test in this testcase?

[Kev Bowring (flocculant)]

> It is not a problem, so solution should be remove Unity DE specific test in
> this testcase?

Unless a test is very specific then any testcase should be able to run properly on any flavour - so no DE specific.

So rather than just remove anything which is specific - reword it so it works everywhere.

[Nicholas Skaggs (nskaggs)]

Lysenko, first of all, thanks for contributing! As flocculant mentioned, it's best to make each testcase a seperate MP so it can be reviewed independently. That avoids the problem of us wanting to merge your vlc changes, but not the orca ones just yet.

Now, on the Orca changes, thanks for fixing these up. We're concerned about the testcase being out of date again or invalid for other flavors. It would be great if you could try it out on a xubuntu or lubuntu install and make sure these directions still make sense.

All that said, I'm ok with landing this for now. Thanks again for your contribution. I hope to see more MP's in the future.

review: Approve

=== modified file 'testcases/packages/1426_Orca'
--- testcases/packages/1426_Orca	2013-08-03 10:34:11 +0000
+++ testcases/packages/1426_Orca	2015-10-26 16:00:32 +0000
@@ -1,19 +1,17 @@
-Test-case name: orca/starting_orca
 This test will check that Orca can play a welcome message
 <dl>
     <dt> Open Dash type 'system settings' and launch the system settings tool</dt>
         <dd>system settings opens and contains the Universal Access section</dd>
     <dt> Select the Universal Access section</dt>
         <dd>a dialog with accessibility settings opens, you are on the 'seeing' tab.</dd>
-    <dt> Select the Screen Reader option</dt>
-        <dd>Did a voice say "welcome to orca"?</dd>
+    <dt> Select the Screen Reader option "On"</dt>
+        <dd>Did a voice say "Screen reader ON"?</dd>
 </dl>
 
-Test-case name: orca/dash
 This test will check that Orca can announce text in the dash
 <dl>
     <dt> press the super(windows) key to bring up the dash</dt>
-        <dd>a voice says 'Dash frame'</dd>
+        <dd>a voice says 'Unity Dash window, entry'</dd>
     <dt> use the cursor keys to navigate around the dash</dt>
         <dd>a voice should read out options as you select them</dd>
     <dt> move down to the lens list at the bottom of the dash</dt>
@@ -22,7 +20,6 @@
         <dd>Did the voice announce you are on the applications lens?</dd>
 </dl>
 
-Test-case name: orca/HUD
 This test will check that Orca can announce text in the HUD
 <dl>
     <dt> from the dash launch the gedit application</dt>
@@ -33,7 +30,6 @@
         <dd>Are the options read out by orca? Does selecting an option operate that menu item in the gedit window?</dd>
 </dl>
 
-Test-case name: orca/Ubiquity
 This test will check that Orca can announce text in Ubiquity
 <dl>
     <dt> boot a live CD, when you hear the drums press ctrl+s</dt>
@@ -42,7 +38,6 @@
         <dd>Are you able to hear all of the options read by orca? Are you able to install without needing to use the mouse?</dd>
 </dl>
 
-Test-case name: orca/globalmenu
 This test will check that Orca can announce text in global menu
 <dl>
     <dt> in an application with a global menu press alt to bring up the menu</dt>
@@ -53,12 +48,11 @@
         <dd>Is the shortcut read to you?</dd>
 </dl>
 
-Test-case name: orca/indicators
 This test will check that Orca can announce text in indicators
 <dl>
-    <dt> press F10 to get to the global menu then use the right cursor to go through the menu to the indicators</dt>
+    <dt> press Alt + F10 to get to the global menu then use the right cursor to go through the menu to the indicators</dt>
         <dd>the indicator names should be read out</dd>
-    <dt> press F10 to leave the menu then F10 again to go back, but this time go left</dt>
+    <dt> press Alt + F10 to leave the menu then Alt + F10 again to go back, but this time go left</dt>
         <dd>this should take you direct to the indicators</dd>
     <dt> navigate around the indicators using the cursor keys</dt>
         <dd>you should get a commentary of all items and should not get stuck anywhere.</dd>
@@ -68,14 +62,12 @@
         <dd>Did the music application start? It should not start without asking it to do so.</dd>
 </dl>
 
-Test-case name: orca/notifications
 This test will check that Orca can announce notifications
 <dl>
     <dt> cause a notification to happen by sending yourself an email, instant message, irc message, etc.</dt>
         <dd>Does the screen reader should read notification out loud?</dd>
 </dl>
 
-Test-case name: orca/launcher
 This test will check that Orca can announce text in quicklists
 <dl>
     <dt> press alt+f1 to get to keyboard navigation of the launcher</dt>
@@ -84,7 +76,6 @@
         <dd>Does orca read the quicklist contents?</dd>
 </dl>
 
-Test-case name: orca/workspace_switcher
 This test will check that Orca can announce text in workspace switcher
 <dl>
     <dt> try using the workspace switcher with the screen reader</dt>

=== modified file 'testcases/packages/1647_vlc'
--- testcases/packages/1647_vlc	2014-07-28 06:47:48 +0000
+++ testcases/packages/1647_vlc	2015-10-26 16:00:32 +0000
@@ -1,3 +1,5 @@
+<em>Testcase requires use of video and/or audio files</em>
+
 This test will check that VLC can open an audio file
 <dl>
     <dt>Launch VLC</dt>
@@ -16,5 +18,37 @@
         <dd>The video is stopped</dd>
 </dl>
 
+This test will check VLC track slider
+<dl>
+    <dt>Go to Media > Click on 'Open File'..., select a video/audio file and press Open</dt>
+	<dd>The selected video/audio is played</dd>
+    <dt>In the bottom of window change current playing time by clicking at the random place of the VLC track slider<dt>
+	<dd>Played audio/video timing changed, audio/video still playing</dd> 
+</dl>
+
+This test will check VLC volume control
+<dl>
+    <dt>Go to Media > Click on 'Open File'..., select a video/audio file and press Open</dt>
+	<dd>The selected video/audio is played</dd>
+    <dt>In the bottom right corner of the window change volume by moving green slider in triangle</dt>
+	<dd>Playback volume changed</dd>
+    <dt>In the bottom right corner of the window press "mute" icon (small speaker icon)</dt>
+	<dd>Playback volume muted</dd>
+</dl>
+
+This test will check VLC control panel
+<dl>
+    <dt>Go to Media > Click on 'Open File'..., select two different video/audio files and press Open</dt>
+	<dd>The selected video/audio is played</dd>
+    <dt>Click on "Pause the playback" button at the bottom</dt>
+	<dd>The selected video/audio is paused</dt>
+    <dt>Click on "Play" button at the bottom</dt>
+	<dd>Video/audio is resumed from where it was paused</dt>
+    <dt>Click on "Next media" button at the bottom</dt>
+	<dd>The next file in the list starts playing</dd>
+    <dt>Click on 'Stop playback' button at the bottom</dt>
+        <dd>The video is stopped</dd>
+</dl>
+
 <strong>If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.
     If an action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> a 'failed' result and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result.</strong>