Ubuntu Settings Components

Merge lp:~phablet-team/ubuntu-settings-components/set-albumart-size into lp:ubuntu-settings-components

  1. set-albumart-size
  2. Merge into trunk
Proposed by Jim Hodapp
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 148
Merged at revision: 147
Proposed branch: lp:~phablet-team/ubuntu-settings-components/set-albumart-size
Merge into: lp:ubuntu-settings-components
Diff against target: 22 lines (+6/-0)
1 file modified
plugins/Ubuntu/Settings/Menus/MediaPlayerMenu.qml (+6/-0)
To merge this branch: bzr merge lp:~phablet-team/ubuntu-settings-components/set-albumart-size
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Andrea Cimitan (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+297469@code.launchpad.net

Commit message

Make sure a size is specified for the albumArtImage for indicator-sound or else the albumart lookup via thumbnailer will fail and the albumArtImage will not render.

Description of the change

Make sure a size is specified for the albumArtImage for indicator-sound or else the albumart lookup via thumbnailer will fail and the albumArtImage will not render.

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:147
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/35/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/1977/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2003/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/35/rebuild

review: Needs Fixing (continuous-integration)
lp:~phablet-team/ubuntu-settings-components/set-albumart-size updated
148. By Jim Hodapp

Add proper spacing after ':' char

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:148
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/36/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/1979/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2005/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/36/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) :
review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:148
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/37/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/1990/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2018/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/37/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/Ubuntu/Settings/Menus/MediaPlayerMenu.qml'
2--- plugins/Ubuntu/Settings/Menus/MediaPlayerMenu.qml 2016-02-11 11:23:02 +0000
3+++ plugins/Ubuntu/Settings/Menus/MediaPlayerMenu.qml 2016-06-15 14:36:47 +0000
4@@ -20,6 +20,7 @@
5 import Ubuntu.Components 1.3
6 import Ubuntu.Components.ListItems 1.3 as ListItem
7 import QtQuick.Layouts 1.1
8+import Ubuntu.Thumbnailer 0.1
9
10 ListItem.Empty {
11 id: menu
12@@ -81,6 +82,11 @@
13
14 image: Image {
15 id: albumArtImage
16+ width: units.gu(8)
17+ height: width
18+ fillMode: Image.PreserveAspectFit
19+ sourceSize: Qt.size(width, height)
20+ anchors.centerIn: parent
21 }
22 }
23

Subscribers

People subscribed via source and target branches