Merge lp:~phablet-team/telephony-service/add-gdb-to-tests into lp:telephony-service

Proposed by Tiago Salem Herrmann
Status: Approved
Approved by: Gustavo Pichorim Boiko
Approved revision: 1254
Proposed branch: lp:~phablet-team/telephony-service/add-gdb-to-tests
Merge into: lp:telephony-service
Prerequisite: lp:telephony-service/staging
Diff against target: 24 lines (+2/-1)
2 files modified
cmake/modules/GenerateTest.cmake (+1/-1)
debian/control (+1/-0)
To merge this branch: bzr merge lp:~phablet-team/telephony-service/add-gdb-to-tests
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+320750@code.launchpad.net

Commit message

Run tests under gdb.

Description of the change

Run tests under gdb.

To post a comment you must log in.
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1254
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/3/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/2351/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2351
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2169
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2169/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2169/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2169
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2169/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2169
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2169/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2169
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2169/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2169/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/3/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

1254. By Tiago Salem Herrmann

add gdb as build-dep

1253. By Tiago Salem Herrmann

add gdb to tests

1252. By Gustavo Pichorim Boiko

Disable PA on tests.

1251. By Gustavo Pichorim Boiko

Monitor app and disconnect/connect accounts when appropriate.

1250. By Gustavo Pichorim Boiko

Implemented contact match by online accounts (IRC).

1249. By Gustavo Pichorim Boiko

Export startChat to QML.

1248. By Gustavo Pichorim Boiko

Expose the account parameters to QML

1247. By Gustavo Pichorim Boiko

Add ParticipantsModel

1246. By Gustavo Pichorim Boiko

- Multiple performance improvements on Roles Interfaces and ContactWatcher
- Changed upstart job to also launch telephony-service-indicator on desktop

1245. By Gustavo Pichorim Boiko

Implement AudioRouteManager in telephony-service-handler

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/modules/GenerateTest.cmake'
2--- cmake/modules/GenerateTest.cmake 2017-03-23 03:54:18 +0000
3+++ cmake/modules/GenerateTest.cmake 2017-03-23 03:54:18 +0000
4@@ -90,7 +90,7 @@
5 endif ()
6
7 add_test(${TESTNAME} ${DBUS_RUNNER} --keep-env --dbus-config=${CMAKE_BINARY_DIR}/tests/common/dbus-session.conf --max-wait=${ARG_TIMEOUT}
8- ${ARG_TASKS} --task ${TEST_COMMAND} --task-name ${TESTNAME})
9+ ${ARG_TASKS} --task /usr/bin/gdb -p -ex -p run -p -ex -p bt -p -ex -p quit -p --args -p ${TEST_COMMAND} --task-name ${TESTNAME})
10 else ()
11 add_test(${TESTNAME} ${CMAKE_CURRENT_BINARY_DIR}/${TESTNAME} ${PLATFORM} -o -,txt -o ${CMAKE_BINARY_DIR}/test_${TESTNAME}.xml,xunitxml)
12 endif()
13
14=== modified file 'debian/control'
15--- debian/control 2017-03-23 03:54:18 +0000
16+++ debian/control 2017-03-23 03:54:18 +0000
17@@ -7,6 +7,7 @@
18 dconf-cli,
19 debhelper (>= 9),
20 dh-translations,
21+ gdb,
22 gnome-keyring,
23 gsettings-ubuntu-schemas,
24 libhistoryservice-dev,

Subscribers

People subscribed via source and target branches

to all changes: