Merge lp:~phablet-team/telephony-service/account-with-emtpy-credentials into lp:telephony-service

[Renato Araujo Oliveira Filho]

[accounts] Store a empty credentials to avoid accounts screen to get stuck when called from app.

[system-apps-ci-bot (system-apps-ci-bot)]

PASSED: Continuous integration, rev:1255
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/4/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2360
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2360
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2177
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2177/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2177
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2177/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2177
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2177/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2177
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2177/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2177
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2177/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2177
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2177/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/4/rebuild

review: Approve (continuous-integration)

[Gustavo Pichorim Boiko (boiko)]

Looks good!

review: Approve

Unmerged revisions

1255. By Renato Araujo Oliveira Filho on 2017-03-28

[accounts] Store a empty credentials to avoid accounts screen to get stuck when called from app.

1254. By Tiago Salem Herrmann on 2017-03-23

add gdb as build-dep

1253. By Tiago Salem Herrmann on 2017-03-23

add gdb to tests

1252. By Gustavo Pichorim Boiko on 2017-03-23

Disable PA on tests.

1251. By Gustavo Pichorim Boiko on 2017-03-22

Monitor app and disconnect/connect accounts when appropriate.

1250. By Gustavo Pichorim Boiko on 2017-03-22

Implemented contact match by online accounts (IRC).

1249. By Gustavo Pichorim Boiko on 2017-03-22

Export startChat to QML.

1248. By Gustavo Pichorim Boiko on 2017-03-22

Expose the account parameters to QML

1247. By Gustavo Pichorim Boiko on 2017-03-22

Add ParticipantsModel

1246. By Gustavo Pichorim Boiko on 2017-03-22

- Multiple performance improvements on Roles Interfaces and ContactWatcher
- Changed upstart job to also launch telephony-service-indicator on desktop

=== modified file 'accounts/common/DynamicField.qml'
--- accounts/common/DynamicField.qml	2017-03-28 12:27:55 +0000
+++ accounts/common/DynamicField.qml	2017-03-28 12:27:55 +0000
@@ -28,6 +28,7 @@
     property var model
     readonly property string value: status === Loader.Ready ? item.value : ""
     readonly property bool isEmpty: status === Loader.Ready ? item.isEmpty : true
+    signal changed()
 
     Component {
         id: stringField

=== modified file 'accounts/common/NewAccountInterface.qml'
--- accounts/common/NewAccountInterface.qml	2017-03-28 12:27:55 +0000
+++ accounts/common/NewAccountInterface.qml	2017-03-28 12:27:55 +0000
@@ -117,7 +117,7 @@
         account.updateDisplayName(formatDisplayName(inputFields))
 
         serviceIM.updateSettings(settingsIM)
-        //serviceIM.credentials = creds
+        serviceIM.credentials = creds
         //serviceIM.updateServiceEnabled(true)
     }
 
@@ -178,13 +178,11 @@
         var info = root.parseCrendentials()
         // save account
         account.updateDisplayName(info.userName)
+        creds.userName = info.userName
         if (root.hasCrendentials) {
-            creds.userName = info.userName
             creds.secret = info.password
-            creds.sync()
-        } else {
-            continueAccountSave(null)
         }
+        creds.sync()
     }
 
     Column {
@@ -289,10 +287,7 @@
         caption: account.provider.id
         acl: "*" // untill later
         storeSecret: true
-        onCredentialsIdChanged: {
-            console.debug("Credetials id changed")
-            root.credentialsStored()
-        }
+        onCredentialsIdChanged: root.credentialsStored()
     }
 
     // necessary to store settings on the "IM" service