Merge lp:~phablet-team/qtubuntu-media/fix-1447606 into lp:qtubuntu-media

Proposed by Jim Hodapp
Status: Merged
Approved by: Jim Hodapp
Approved revision: 73
Merged at revision: 70
Proposed branch: lp:~phablet-team/qtubuntu-media/fix-1447606
Merge into: lp:qtubuntu-media
Diff against target: 15 lines (+3/-1)
1 file modified
src/aal/aalmediaplayercontrol.cpp (+3/-1)
To merge this branch: bzr merge lp:~phablet-team/qtubuntu-media/fix-1447606
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Jim Hodapp (community) Approve
Review via email: mp+257432@code.launchpad.net

Commit message

Fix ringtone not looping (QMediaPlaylist loop mode) regression.

Description of the change

Fix ringtone not looping (QMediaPlaylist loop mode) regression.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
71. By Jim Hodapp

Refine the EndOfMedia logic to make sure it works for ringtones, video and music playback.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
72. By Jim Hodapp

EndOfMedia working even better for all audio types and roles.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
73. By Ricardo Mendoza

Stop backend only if media has been reloaded as a result of EOS

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/aal/aalmediaplayercontrol.cpp'
2--- src/aal/aalmediaplayercontrol.cpp 2015-03-20 13:12:42 +0000
3+++ src/aal/aalmediaplayercontrol.cpp 2015-04-27 20:54:43 +0000
4@@ -280,8 +280,10 @@
5 qDebug() << __PRETTY_FUNCTION__ << endl;
6 // The order of these lines is very important to keep music-app,
7 // mediaplayer-app and the QMediaPlaylist loop cases all happy
8- stop();
9 setMediaStatus(QMediaPlayer::EndOfMedia);
10+ // Stop the Player if no media has been loaded as result of EOS
11+ if (m_status == QMediaPlayer::EndOfMedia)
12+ stop();
13 m_service->setPosition(0);
14 Q_EMIT positionChanged(position());
15 if (isVideoAvailable())

Subscribers

People subscribed via source and target branches

to all changes: