Merge lp:~phablet-team/qtubuntu-media/enable-mpris-controls into lp:qtubuntu-media/stable
Proposed by
Jim Hodapp
Status: | Merged |
---|---|
Approved by: | Alfonso Sanchez-Beato |
Approved revision: | no longer in the source branch. |
Merged at revision: | 86 |
Proposed branch: | lp:~phablet-team/qtubuntu-media/enable-mpris-controls |
Merge into: | lp:qtubuntu-media/stable |
Diff against target: |
413 lines (+128/-68) 8 files modified
README (+4/-0) debian/control (+1/-1) src/aal/aalmediaplayerservice.cpp (+52/-21) src/aal/aalmediaplayerservice.h (+4/-2) tests/integration/tst_mediaplaylist.cpp (+58/-44) tests/integration/tst_mediaplaylist.h (+4/-0) tests/unit/service.cpp (+4/-0) tests/unit/service.h (+1/-0) |
To merge this branch: | bzr merge lp:~phablet-team/qtubuntu-media/enable-mpris-controls |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alfonso Sanchez-Beato | Approve | ||
Review via email: mp+270445@code.launchpad.net |
Commit message
Make sure the that the current player instance is controlable by MPRIS controls if the type of player is appropriate for playlist control. Also, don't add a track to the tracklist when AalMediaPlayerS
Description of the change
Make sure the that the current player instance is controlable by MPRIS controls if the type of player is appropriate for playlist control. Also, don't add a track to the tracklist when AalMediaPlayerS
To post a comment you must log in.
Looks good, some minor issues detected. I would also like to have a branch for trunk too.