Merge lp:~phablet-team/ofono/ofono-mwi-and-bugs into lp:~phablet-team/ofono/ubuntu
Status: | Merged |
---|---|
Merged at revision: | 6854 |
Proposed branch: | lp:~phablet-team/ofono/ofono-mwi-and-bugs |
Merge into: | lp:~phablet-team/ofono/ubuntu |
Diff against target: |
280 lines (+150/-19) 7 files modified
debian/changelog (+15/-1) drivers/rilmodem/sim.c (+6/-1) drivers/rilmodem/voicecall.c (+22/-7) gril/grilreply.c (+12/-9) plugins/ril.c (+5/-0) src/smsutil.c (+1/-1) unit/test-grilreply.c (+89/-0) |
To merge this branch: | bzr merge lp:~phablet-team/ofono/ofono-mwi-and-bugs |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Needs Fixing | |
Ricardo Salveti | Pending | ||
Review via email: mp+204587@code.launchpad.net |
This proposal supersedes a proposal from 2014-01-30.
Commit message
* gril, rilmodem/sim, unit: fix SIM IO crash (LP: #1268743)
- cleanup gril_reply_
check and fix memory leak.
- add check for null hex_response in ril_file_io_cb(), as
the emulator can return such responses.
- add additional unit tests to cover crash scenarios.
* ril, src: enable message-
- register message_waiting atom in ril plugin
- fix sms_mwi_dcs_decode bug which prevented incoming message
waiting indications from being set.
* rilmodem/voicecall: fix call-decline bug (LP: #1260988)
Send a RIL_REQUEST_
RIL_
Description of the change
This change includes a couple of upstream changes:
1. Fixes a SIM IO crash that only occurs on the emulator (LP: #1268743).
2. Enables the message-waiting interface in the ril device plugin.
This exposes a new ofono DBus interface ( see doc/message-
for details ) which allows the upper layers to detect when new voicemails
have landed in the user's voicemailbox. It also exposes the voicemailbox
phone number so that the dialer app can implenent a standard voicemail
shortcut ( long press on "1" ).
3. Fixe a bug with certain operators where declining an incoming call leads to
a fast busy signal instead of voicemail ( LP: #1260988 ).
Tested on mako, maguro, and the emulator using build #121. Please see bug descriptions
for testing instruction, and the specified documentation for the new message-waiting
API.
PASSED: Continuous integration, rev:6854 jenkins. qa.ubuntu. com/job/ phablet- team-ofono- ubuntu- ci/22/ jenkins. qa.ubuntu. com/job/ phablet- team-ofono- ubuntu- trusty- amd64-ci/ 15 jenkins. qa.ubuntu. com/job/ phablet- team-ofono- ubuntu- trusty- armhf-ci/ 15 jenkins. qa.ubuntu. com/job/ phablet- team-ofono- ubuntu- trusty- armhf-ci/ 15/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ phablet- team-ofono- ubuntu- trusty- i386-ci/ 15
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/phablet- team-ofono- ubuntu- ci/22/rebuild
http://