Merge lp:~phablet-team/network-manager/lp1445134-wifi-scan-fix-vivid into lp:~phablet-team/network-manager/vivid-phone-overlay

Proposed by Tony Espy
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 966
Merged at revision: 966
Proposed branch: lp:~phablet-team/network-manager/lp1445134-wifi-scan-fix-vivid
Merge into: lp:~phablet-team/network-manager/vivid-phone-overlay
Diff against target: 64 lines (+15/-6)
2 files modified
debian/changelog (+7/-0)
debian/patches/0002-wifi-cull-the-scan-list-before-signalling-ScanDone-b.patch (+8/-6)
To merge this branch: bzr merge lp:~phablet-team/network-manager/lp1445134-wifi-scan-fix-vivid
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Review via email: mp+267079@code.launchpad.net

Description of the change

This change restores periodic WiFi scanning, which was broken due to a mangling of a patch when NM was re-based on 0.9.10.0.

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) :
review: Approve
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

This should land in wily first though, given that it's pretty much a SRU.

Revision history for this message
Tony Espy (awe) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-07-09 18:24:56 +0000
3+++ debian/changelog 2015-08-05 17:15:41 +0000
4@@ -1,3 +1,10 @@
5+network-manager (0.9.10.0-4ubuntu15.1.7) vivid; urgency=medium
6+
7+ * d/p/0002-wifi-cull-the-scan-list-before-signalling-ScanDone-b.patch:
8+ restore periodic WiFi scanning (LP: #1445134).
9+
10+ -- Tony Espy <espy@canonical.com> Wed, 05 Aug 2015 12:20:43 -0400
11+
12 network-manager (0.9.10.0-4ubuntu15.1.6) vivid; urgency=medium
13
14 * debian/patches/lp1361864-add-ofono-preferred-contexts.patch: fix
15
16=== modified file 'debian/patches/0002-wifi-cull-the-scan-list-before-signalling-ScanDone-b.patch'
17--- debian/patches/0002-wifi-cull-the-scan-list-before-signalling-ScanDone-b.patch 2015-04-20 16:29:33 +0000
18+++ debian/patches/0002-wifi-cull-the-scan-list-before-signalling-ScanDone-b.patch 2015-08-05 17:15:41 +0000
19@@ -14,10 +14,10 @@
20 src/devices/wifi/nm-device-wifi.c | 33 +++++++++++++++++++++++++++------
21 1 file changed, 27 insertions(+), 6 deletions(-)
22
23-Index: b/src/devices/wifi/nm-device-wifi.c
24+Index: network-manager-0.9.10.0/src/devices/wifi/nm-device-wifi.c
25 ===================================================================
26---- a/src/devices/wifi/nm-device-wifi.c
27-+++ b/src/devices/wifi/nm-device-wifi.c
28+--- network-manager-0.9.10.0.orig/src/devices/wifi/nm-device-wifi.c
29++++ network-manager-0.9.10.0/src/devices/wifi/nm-device-wifi.c
30 @@ -183,6 +183,10 @@ static void supplicant_iface_notify_scan
31 GParamSpec * pspec,
32 NMDeviceWifi * self);
33@@ -29,7 +29,7 @@
34 static void schedule_scanlist_cull (NMDeviceWifi *self);
35
36 static gboolean request_wireless_scan (gpointer user_data);
37-@@ -1609,14 +1613,20 @@ supplicant_iface_scan_done_cb (NMSupplic
38+@@ -1609,14 +1613,22 @@ supplicant_iface_scan_done_cb (NMSupplic
39 nm_device_get_iface (NM_DEVICE (self)),
40 success ? "successful" : "failed");
41
42@@ -51,10 +51,12 @@
43 + * all last-seen timestamps being updated.
44 + */
45 + g_signal_emit (self, signals[SCAN_DONE], 0, NULL);
46++
47++ schedule_scan (self, success);
48
49 if (priv->requested_scan) {
50 priv->requested_scan = FALSE;
51-@@ -1793,8 +1803,10 @@ cull_scan_list (NMDeviceWifi *self)
52+@@ -1793,8 +1805,10 @@ cull_scan_list (NMDeviceWifi *self)
53 * supplicant in the last scan.
54 */
55 if ( nm_ap_get_supplicant_path (ap)
56@@ -66,7 +68,7 @@
57
58 last_seen = nm_ap_get_last_seen (ap);
59 if (!last_seen || last_seen + prune_interval_s < boottime_now)
60-@@ -1836,13 +1848,22 @@ cull_scan_list (NMDeviceWifi *self)
61+@@ -1836,13 +1850,22 @@ cull_scan_list (NMDeviceWifi *self)
62 }
63
64 static void

Subscribers

People subscribed via source and target branches

to all changes: