Merge lp:~phablet-team/messaging-framework/notify-group-creation-rejected into lp:messaging-framework

[Roberto Mier Escandon]

Moved callbacks
- on_group_created()
- on_group_creation_rejected()
to GroupManager. They were previously in a GroupStarter observer but that does not make sense, since is into the textchannel where the callbacks for the result of creating the group in the server should be announced.
Now, if received on_group_creation_rejected() callback, selfHandle() is removed from group members

Moved callbacks
- on_group_created()
- on_group_creation_rejected()
to GroupManager. They were previously in a GroupStarter observer but that does not make sense, since is into the textchannel where the callbacks for the result of creating the group in the server should be announced.
Now, if received on_group_creation_rejected() callback, selfHandle() is removed from group members

[lp:~phablet-team/messaging-framework/notify-group-creation-rejected]

30. By Roberto Mier Escandon on 2016-06-08

updated changelog

[Gustavo Pichorim Boiko (boiko)]

Looks good!

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2016-06-07 02:05:40 +0000
+++ debian/changelog	2016-06-08 15:37:53 +0000
@@ -1,3 +1,11 @@
+messaging-framework (0.1-1ubuntu13) vivid; urgency=medium
+
+  * Session creation rejection removes self handle
+  * Added signals to start and stop typing
+  * Added code for telepathy to know when the plugin receives is_typing callback
+
+ -- Roberto Mier Escandon <[e-mail]>  Wed, 08 Jun 2016 17:35:10 +0200
+
 messaging-framework (0.1-1ubuntu12) vivid; urgency=medium
 
   * Update members method in textchannel using isolated methods for adding and

=== modified file 'include/messaging/connector.h'
--- include/messaging/connector.h	2016-05-16 10:33:21 +0000
+++ include/messaging/connector.h	2016-06-08 15:37:53 +0000
@@ -55,7 +55,6 @@
     virtual std::shared_ptr<Connection> request_connection(const std::shared_ptr<messaging::Connection::Observer>& connection_observer,
                                                 const std::shared_ptr<messaging::Messenger::Observer>& messenger_observer,
                                                 const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer,
-                                                const std::shared_ptr<messaging::GroupStarter::Observer>& group_starter_observer,
                                                 const messaging::Dictionary<std::string, messaging::Variant>& dict) = 0;
 
 protected:

=== modified file 'include/messaging/group_manager.h'
--- include/messaging/group_manager.h	2016-05-18 21:37:35 +0000
+++ include/messaging/group_manager.h	2016-06-08 15:37:53 +0000
@@ -39,6 +39,8 @@
     public:
         virtual ~Observer() = default;
 
+        virtual void on_group_created() = 0;
+        virtual void on_group_creation_rejected() = 0;
         virtual void on_group_cancelled() = 0;
         virtual void on_group_quit() = 0;
         virtual void on_group_title_changed(const std::string& new_title, const User& actor, const std::chrono::system_clock::time_point& when) = 0;
@@ -78,6 +80,9 @@
 
     void validate_observer();
 
+    void announce_group_created();
+    //TODO TRACE maybe a reason as parameter for knowing the rejected cause?
+    void announce_group_creation_rejected();
     void announce_group_cancelled();
     void announce_group_quit();
     void announce_group_title_changed(const std::string& new_title,

=== modified file 'include/messaging/group_starter.h'
--- include/messaging/group_starter.h	2016-05-17 10:57:36 +0000
+++ include/messaging/group_starter.h	2016-06-08 15:37:53 +0000
@@ -17,18 +17,7 @@
 class MESSAGING_FW_PUBLIC GroupStarter : public NonCopyable, NonMovable
 {
 public:
-    /// @brief Observer provides means to monitor the state of a GroupStarter instance.
-    class Observer : NonCopyable, NonMovable
-    {
-    public:
-        virtual ~Observer() = default;
-
-        virtual void on_group_created(const std::string& id) = 0;
-        virtual void on_group_creation_rejected(const std::string& id) = 0;
-
-    protected:
-        Observer() = default;
-    };
+    virtual ~GroupStarter() = default;
 
     /// @brief create_group initiate group from app
     virtual std::shared_ptr<GroupManager> create_group(const std::shared_ptr<Group> &group) = 0;
@@ -41,15 +30,7 @@
 
 protected:
     /// @brief GroupStarter constructs a new instance.
-    GroupStarter(const std::shared_ptr<Observer> &observer);
-
-    void announce_group_created(const std::string& id);
-    void announce_group_creation_rejected(const std::string& id);
-
-    /// @cond
-    struct Private;
-    std::shared_ptr<Private> impl;
-    /// @endcond
+    GroupStarter() = default;
 };
 
 }

=== modified file 'include/messaging/plugin_connector.h'
--- include/messaging/plugin_connector.h	2016-05-16 10:33:21 +0000
+++ include/messaging/plugin_connector.h	2016-06-08 15:37:53 +0000
@@ -85,8 +85,7 @@
     std::shared_ptr<Connection> request_connection(const std::shared_ptr<messaging::Connection::Observer>& connection_observer,
                                                    const std::shared_ptr<messaging::Messenger::Observer>& messenger_observer,
                                                    const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer,
-                                                   const std::shared_ptr<messaging::GroupStarter::Observer>& group_starter_observer,
-                                        const messaging::Dictionary<std::string, messaging::Variant>& dict) override;
+                                                   const messaging::Dictionary<std::string, messaging::Variant>& dict) override;
 
 private:
     std::shared_ptr<NamedSymbolLoader> named_symbol_loader;

=== modified file 'include/messaging/qt/tp/connection.h'
--- include/messaging/qt/tp/connection.h	2016-05-16 18:12:38 +0000
+++ include/messaging/qt/tp/connection.h	2016-06-08 15:37:53 +0000
@@ -48,7 +48,6 @@
         , public messaging::Connection::Observer
         , public messaging::Messenger::Observer
         , public messaging::PresenceManager::Observer
-        , public messaging::GroupStarter::Observer
 {
     Q_OBJECT
 public:
@@ -77,7 +76,6 @@
             : public messaging::Connection::Observer
             , public messaging::Messenger::Observer
             , public messaging::PresenceManager::Observer
-            , public messaging::GroupStarter::Observer
             , public std::enable_shared_from_this<Observer>
     {
       public:
@@ -99,9 +97,6 @@
         void on_new_group_invitation_received(const messaging::Recipient::shared_ptr& new_group,
                                               const messaging::Recipient::shared_ptr& initiator) override;
 
-        void on_group_created(const std::string& id) override;
-        void on_group_creation_rejected(const std::string& id) override;
-
       private:
         std::shared_ptr<qt::Runtime> runtime; ///< The qt::Runtime instance that we dispatch to.
         Tp::SharedPtr<Connection> connection; ///< The managed connection instance.
@@ -126,9 +121,6 @@
     void on_new_group_invitation_received(const messaging::Recipient::shared_ptr& new_group,
                                           const messaging::Recipient::shared_ptr& initiator) override;
 
-    void on_group_created(const std::string& id) override;
-    void on_group_creation_rejected(const std::string& id) override;
-
     /// @brief Creates a new instance for the given parameters, setting up
     /// fixed and optional properties supported on this connection.
     Connection(const std::shared_ptr<Connector>& connector,

=== modified file 'include/messaging/qt/tp/text_channel.h'
--- include/messaging/qt/tp/text_channel.h	2016-06-08 15:37:53 +0000
+++ include/messaging/qt/tp/text_channel.h	2016-06-08 15:37:53 +0000
@@ -72,6 +72,12 @@
     /// @brief on_closed received when the chat is no longer valid
     void on_closed() override;
 
+    /// @brief on_group_created when the group has been created ok in the server
+    void on_group_created() override;
+
+    /// @brief on_group_creation_rejected when the group creation has been rejected by the server
+    void on_group_creation_rejected() override;
+
     /// @brief on_group_cancelled when the group is no longer valid
     void on_group_cancelled() override;
 
@@ -137,6 +143,12 @@
         /// @brief on_closed received when the chat is no longer valid and must be disposed.
         void on_closed() override;
 
+        /// @brief on_group_created when the group has been created ok in the server
+        void on_group_created() override;
+
+        /// @brief on_group_creation_rejected when the group creation has been rejected by the server
+        void on_group_creation_rejected() override;
+
         /// @brief on_group_cancelled when the group is no longer valid
         void on_group_cancelled() override;
 

=== modified file 'src/CMakeLists.txt'
--- src/CMakeLists.txt	2016-05-30 16:43:03 +0000
+++ src/CMakeLists.txt	2016-06-08 15:37:53 +0000
@@ -14,7 +14,6 @@
   messaging/chat.cpp
   messaging/group.cpp
   messaging/group_manager.cpp
-  messaging/group_starter.cpp
   messaging/has_interfaces.cpp
   messaging/connection.cpp
   messaging/connector_factory_initializer.cpp

=== modified file 'src/messaging/group_manager.cpp'
--- src/messaging/group_manager.cpp	2016-05-16 13:13:01 +0000
+++ src/messaging/group_manager.cpp	2016-06-08 15:37:53 +0000
@@ -40,6 +40,19 @@
     }
 }
 
+void messaging::GroupManager::announce_group_created()
+{
+    validate_observer();
+    impl->observer->on_group_created();
+}
+
+void messaging::GroupManager::announce_group_creation_rejected()
+{
+    validate_observer();
+    impl->observer->on_group_creation_rejected();
+}
+
+
 void messaging::GroupManager::announce_group_cancelled()
 {
     validate_observer();

=== removed file 'src/messaging/group_starter.cpp'
--- src/messaging/group_starter.cpp	2016-05-16 18:12:38 +0000
+++ src/messaging/group_starter.cpp	1970-01-01 00:00:00 +0000
@@ -1,42 +0,0 @@
-/*
- * Copyright © 2016 Canonical Ltd.
- *
- * This program is free software: you can redistribute it and/or modify it
- * under the terms of the GNU Lesser General Public License version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-#include <messaging/group_starter.h>
-
-class messaging::GroupStarter::Private
-{
-public:
-    Private(const std::shared_ptr<messaging::GroupStarter::Observer>& obs)
-        : observer{obs} {}
-    ~Private() {}
-
-    std::shared_ptr<messaging::GroupStarter::Observer> observer;
-};
-
-messaging::GroupStarter::GroupStarter(const std::shared_ptr<messaging::GroupStarter::Observer>& observer)
-        : impl{new Private{observer}}
-{
-}
-
-void messaging::GroupStarter::announce_group_created(const std::string& id)
-{
-    impl->observer->on_group_created(id);
-}
-
-void messaging::GroupStarter::announce_group_creation_rejected(const std::string& id)
-{
-    impl->observer->on_group_creation_rejected(id);
-}

=== modified file 'src/messaging/plugin_connector.cpp'
--- src/messaging/plugin_connector.cpp	2016-05-16 10:33:21 +0000
+++ src/messaging/plugin_connector.cpp	2016-06-08 15:37:53 +0000
@@ -104,10 +104,9 @@
     const std::shared_ptr<messaging::Connection::Observer>& connection_observer,
     const std::shared_ptr<messaging::Messenger::Observer>& messenger_observer,
     const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer,
-    const std::shared_ptr<messaging::GroupStarter::Observer>& group_starter_observer,
     const messaging::Dictionary<std::string, messaging::Variant>& dict)
 {
-    return connector->request_connection(connection_observer, messenger_observer, presence_observer, group_starter_observer, dict);
+    return connector->request_connection(connection_observer, messenger_observer, presence_observer, dict);
 }
 
 void messaging::PluginConnector::run()

=== modified file 'src/messaging/qt/tp/connection.cpp'
--- src/messaging/qt/tp/connection.cpp	2016-06-02 16:53:11 +0000
+++ src/messaging/qt/tp/connection.cpp	2016-06-08 15:37:53 +0000
@@ -31,6 +31,8 @@
 
 #include <iostream>
 
+#include <glog/logging.h>
+
 #define MQT_TP_RECIPIENT "messaging-framework-qt-tp-recipient"
 
 Q_DECLARE_METATYPE(messaging::Recipient::shared_ptr)
@@ -86,22 +88,6 @@
                              });
 }
 
-void mqt::tp::Connection::Observer::on_group_created(const std::string &id)
-{
-    auto sp = shared_from_this();
-    runtime->enter_with_task([sp, id](){
-                                sp->connection->on_group_created(id);
-                            });
-}
-
-void mqt::tp::Connection::Observer::on_group_creation_rejected(const std::string &id)
-{
-    auto sp = shared_from_this();
-    runtime->enter_with_task([sp, id](){
-                                sp->connection->on_group_creation_rejected(id);
-                            });
-}
-
 Tp::SharedPtr<mqt::tp::Connection> mqt::tp::Connection::create(const std::shared_ptr<msg::Connector>& connector,
                                                                const std::shared_ptr<mqt::Runtime>& runtime,
                                                                const QString& connection_manager_name,
@@ -158,7 +144,7 @@
     , runtime{runtime}
     , connector{connector}
     , observer{std::make_shared<mqt::tp::Connection::Observer>(runtime, Tp::SharedPtr<mqt::tp::Connection>{this})}
-    , connection{connector->request_connection(observer, observer, observer, observer, mqt::VariantMapFacade{parameters})}
+    , connection{connector->request_connection(observer, observer, observer, mqt::VariantMapFacade{parameters})}
 {
     qRegisterMetaType<messaging::Recipient::shared_ptr>();
 
@@ -346,20 +332,6 @@
     }
 }
 
-//TODO TRACE
-#include <glog/logging.h>
-void mqt::tp::Connection::on_group_created(const std::string &id)
-{
-    //TODO IMPLEMENT
-    LOG(INFO) << __PRETTY_FUNCTION__ << " id:" << id;
-}
-
-void mqt::tp::Connection::on_group_creation_rejected(const std::string &id)
-{
-    //TODO IMPLEMENT
-    LOG(INFO) << __PRETTY_FUNCTION__ << " id:" << id;
-}
-
 void mqt::tp::Connection::connect(Tp::DBusError* error) noexcept(true)
 {
     try

=== modified file 'src/messaging/qt/tp/text_channel.cpp'
--- src/messaging/qt/tp/text_channel.cpp	2016-06-08 15:37:53 +0000
+++ src/messaging/qt/tp/text_channel.cpp	2016-06-08 15:37:53 +0000
@@ -160,6 +160,22 @@
         });
 }
 
+void mqt::tp::TextChannel::Observer::on_group_created()
+{
+    auto sp = shared_from_this();
+    runtime->enter_with_task([sp](){
+            sp->tc->on_group_created();
+        });
+}
+
+void mqt::tp::TextChannel::Observer::on_group_creation_rejected()
+{
+    auto sp = shared_from_this();
+    runtime->enter_with_task([sp](){
+            sp->tc->on_group_creation_rejected();
+        });
+}
+
 void mqt::tp::TextChannel::Observer::on_group_cancelled()
 {
     auto thiz = shared_from_this();
@@ -484,6 +500,28 @@
     close();
 }
 
+void mqt::tp::TextChannel::on_group_created()
+{
+    LOG(INFO) << __PRETTY_FUNCTION__;
+}
+
+void mqt::tp::TextChannel::on_group_creation_rejected()
+{
+    LOG(INFO) << __PRETTY_FUNCTION__ ;
+    // Note (rmescandon): at this point, self handle should be removed from the group members, providing one of the reasons
+    // described at:
+    // https://telepathy.freedesktop.org/spec/Channel_Interface_Group.html#Enum:Channel_Group_Change_Reason
+    //
+    // but this should be done using RemoveMembersWithReason method described at spec:
+    // https://telepathy.freedesktop.org/spec/Channel_Interface_Group.html#Method:RemoveMembersWithReason
+    //
+    // still not implemented in telepathy qt
+    //
+    // The alternative is only removing selfHandle from members
+    bcgi->removeMembers(Tp::UIntList() << tp_connection->selfHandle());
+}
+
+
 void mqt::tp::TextChannel::on_group_cancelled()
 {
     close();

=== modified file 'tests/CMakeLists.txt'
--- tests/CMakeLists.txt	2016-05-19 11:56:55 +0000
+++ tests/CMakeLists.txt	2016-06-08 15:37:53 +0000
@@ -38,7 +38,6 @@
     mock_messenger.cpp
     mock_connection.cpp
     mock_connector.cpp
-    mock_group_starter.cpp
 )
 
 # make the .h files visible on qtcreator

=== modified file 'tests/mock_connection.cpp'
--- tests/mock_connection.cpp	2016-05-19 11:56:55 +0000
+++ tests/mock_connection.cpp	2016-06-08 15:37:53 +0000
@@ -21,12 +21,11 @@
 
 MockConnection::MockConnection(const std::shared_ptr<messaging::Connection::Observer>& connection_observer,
                const std::shared_ptr<messaging::Messenger::Observer>& messenger_observer,
-               const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer,
-               const std::shared_ptr<messaging::GroupStarter::Observer>& group_starter_observer)
+               const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer)
     : messaging::Connection{connection_observer}
     , mock_messenger_{std::make_shared<NiceMock<MockMessenger>>(messenger_observer)}
     , mock_presence_manager_{std::make_shared<NiceMock<MockPresenceManager>>(presence_observer)}                                                                        
-    , mock_group_starter_{std::make_shared<NiceMock<MockGroupStarter>>(group_starter_observer)}
+    , mock_group_starter_{std::make_shared<NiceMock<MockGroupStarter>>()}
 {
     ON_CALL(*this, connect()).WillByDefault(Invoke(this, &MockConnection::fake_connect));
     ON_CALL(*this, presence_manager()).WillByDefault(Invoke(this, &MockConnection::fake_presence_manager));

=== modified file 'tests/mock_connection.h'
--- tests/mock_connection.h	2016-05-19 11:56:55 +0000
+++ tests/mock_connection.h	2016-06-08 15:37:53 +0000
@@ -41,8 +41,7 @@
 
     MockConnection(const std::shared_ptr<messaging::Connection::Observer>& connection_observer,
                    const std::shared_ptr<messaging::Messenger::Observer>& messenger_observer,
-                   const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer,
-                   const std::shared_ptr<messaging::GroupStarter::Observer>& group_starter_observer);
+                   const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer);
 
     void announce_status_connected();
 

=== modified file 'tests/mock_connector.cpp'
--- tests/mock_connector.cpp	2016-05-19 11:56:55 +0000
+++ tests/mock_connector.cpp	2016-06-08 15:37:53 +0000
@@ -23,17 +23,16 @@
 MockConnector::MockConnector()
 {
     ON_CALL(*this, parameters()).WillByDefault(ReturnRef(params_));
-    ON_CALL(*this, request_connection(_,_,_,_,_)).WillByDefault(Invoke(this, &MockConnector::fake_request_connection));
+    ON_CALL(*this, request_connection(_,_,_,_)).WillByDefault(Invoke(this, &MockConnector::fake_request_connection));
 }
 
 std::shared_ptr<messaging::Connection> MockConnector::fake_request_connection(
         const std::shared_ptr<messaging::Connection::Observer>& connection_observer,
         const std::shared_ptr<messaging::Messenger::Observer>& messenger_observer,
         const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer,
-        const std::shared_ptr<messaging::GroupStarter::Observer>& group_starter_observer,
         const messaging::Dictionary<std::string, messaging::Variant>&)
 {
-    return std::make_shared<NiceMock<MockConnection>>(connection_observer, messenger_observer, presence_observer, group_starter_observer);
+    return std::make_shared<NiceMock<MockConnection>>(connection_observer, messenger_observer, presence_observer);
 }
 
 }

=== modified file 'tests/mock_connector.h'
--- tests/mock_connector.h	2016-05-19 11:56:55 +0000
+++ tests/mock_connector.h	2016-06-08 15:37:53 +0000
@@ -36,12 +36,11 @@
     MockConnector();
 
     MOCK_CONST_METHOD0(parameters, const messaging::Enumerator<messaging::Parameter>&());
-    MOCK_METHOD5(request_connection,
+    MOCK_METHOD4(request_connection,
                  std::shared_ptr<messaging::Connection>(
                      const std::shared_ptr<messaging::Connection::Observer>& connection_observer,
                      const std::shared_ptr<messaging::Messenger::Observer>& messenger_observer,
                      const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer,
-                     const std::shared_ptr<messaging::GroupStarter::Observer>& group_starter_observer,
                      const messaging::Dictionary<std::string, messaging::Variant>&));
     MOCK_METHOD0(run, void());
     MOCK_METHOD0(stop, void());
@@ -53,7 +52,6 @@
             const std::shared_ptr<messaging::Connection::Observer>& connection_observer,
             const std::shared_ptr<messaging::Messenger::Observer>& messenger_observer,
             const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer,
-            const std::shared_ptr<messaging::GroupStarter::Observer>& group_starter_observer,
             const messaging::Dictionary<std::string, messaging::Variant>&);
 };
 

=== removed file 'tests/mock_group_starter.cpp'
--- tests/mock_group_starter.cpp	2016-05-19 11:56:55 +0000
+++ tests/mock_group_starter.cpp	1970-01-01 00:00:00 +0000
@@ -1,11 +0,0 @@
-#include <tests/mock_group_starter.h>
-
-namespace testing
-{
-
-MockGroupStarter::MockGroupStarter(const std::shared_ptr<messaging::GroupStarter::Observer>& observer)
-    : messaging::GroupStarter{observer}
-{
-}
-
-}

=== modified file 'tests/mock_group_starter.h'
--- tests/mock_group_starter.h	2016-05-19 11:56:55 +0000
+++ tests/mock_group_starter.h	2016-06-08 15:37:53 +0000
@@ -13,14 +13,6 @@
 class MockGroupStarter : public messaging::GroupStarter
 {
 public:
-    struct MockObserver : public messaging::GroupStarter::Observer
-    {
-        MOCK_METHOD1(on_group_created, void(const std::string& id));
-        MOCK_METHOD1(on_group_creation_rejected, void(const std::string& id));
-    };
-
-    MockGroupStarter(const std::shared_ptr<messaging::GroupStarter::Observer>& observer);
-
     MOCK_METHOD1(create_group, std::shared_ptr<messaging::GroupManager>(const std::shared_ptr<messaging::Group>&));
     MOCK_METHOD1(accept_group, std::shared_ptr<messaging::GroupManager>(const std::shared_ptr<messaging::Group>&));
     MOCK_METHOD1(rejoin_group, std::shared_ptr<messaging::GroupManager>(const std::shared_ptr<messaging::Group>&));

=== modified file 'tests/unit/messaging/blocking_connector.cpp'
--- tests/unit/messaging/blocking_connector.cpp	2016-05-19 11:56:55 +0000
+++ tests/unit/messaging/blocking_connector.cpp	2016-06-08 15:37:53 +0000
@@ -27,7 +27,6 @@
     const std::shared_ptr<messaging::Connection::Observer>&,
     const std::shared_ptr<messaging::Messenger::Observer>&,
     const std::shared_ptr<messaging::PresenceManager::Observer>&,
-    const std::shared_ptr<messaging::GroupStarter::Observer>&,
     const messaging::Dictionary<std::string, messaging::Variant>&)
 {
     throw std::logic_error{"Not implemented"};

=== modified file 'tests/unit/messaging/blocking_connector.h'
--- tests/unit/messaging/blocking_connector.h	2016-05-19 11:56:55 +0000
+++ tests/unit/messaging/blocking_connector.h	2016-06-08 15:37:53 +0000
@@ -36,7 +36,6 @@
         const std::shared_ptr<messaging::Connection::Observer>& connection_observer,
         const std::shared_ptr<messaging::Messenger::Observer>& messaging_observer,
         const std::shared_ptr<messaging::PresenceManager::Observer>& presence_observer,
-        const std::shared_ptr<messaging::GroupStarter::Observer>& group_starter_observer,
         const messaging::Dictionary<std::string, messaging::Variant>&) override;
     void run() override;
     void stop() override;

=== modified file 'tests/unit/messaging/plugin_connector_test.cpp'
--- tests/unit/messaging/plugin_connector_test.cpp	2016-05-19 11:56:55 +0000
+++ tests/unit/messaging/plugin_connector_test.cpp	2016-06-08 15:37:53 +0000
@@ -39,7 +39,6 @@
         const std::shared_ptr<messaging::Connection::Observer>&,
         const std::shared_ptr<messaging::Messenger::Observer>&,
         const std::shared_ptr<messaging::PresenceManager::Observer>&,
-        const std::shared_ptr<messaging::GroupStarter::Observer>&,
         const messaging::Dictionary<std::string, messaging::Variant>&) override
     {
         throw std::logic_error{"Not implemented."};