Merge lp:~phablet-team/messaging-framework/create_group_with_title into lp:messaging-framework

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 42
Merged at revision: 41
Proposed branch: lp:~phablet-team/messaging-framework/create_group_with_title
Merge into: lp:messaging-framework
Diff against target: 32 lines (+7/-1)
1 file modified
src/messaging/qt/tp/connection.cpp (+7/-1)
To merge this branch: bzr merge lp:~phablet-team/messaging-framework/create_group_with_title
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Tiago Salem Herrmann (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+299499@code.launchpad.net

Commit message

Make sure we use the initial title if available.

Description of the change

Make sure we use the initial title if available.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

looks good. thanks.

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/messaging/qt/tp/connection.cpp'
2--- src/messaging/qt/tp/connection.cpp 2016-07-05 13:47:29 +0000
3+++ src/messaging/qt/tp/connection.cpp 2016-07-08 03:32:47 +0000
4@@ -559,6 +559,7 @@
5 // received the request. We have to switch to Room type and get the provided information
6
7 messaging::Members initial_invitees;
8+ std::string title;
9 if (hints.contains(TP_QT_IFACE_CHANNEL_INTERFACE_CONFERENCE + QLatin1String(".InitialInviteeIDs")))
10 {
11 QStringList initial_invitees_ids =
12@@ -571,6 +572,11 @@
13 }
14 }
15
16+ if (hints.contains(TP_QT_IFACE_CHANNEL_INTERFACE_ROOM_CONFIG + QLatin1String(".Title")))
17+ {
18+ title = hints[TP_QT_IFACE_CHANNEL_INTERFACE_ROOM_CONFIG + QLatin1String(".Title")].toString().toStdString();
19+ }
20+
21 // check if the client requested a chat room
22 if (hints.contains(TP_QT_IFACE_CHANNEL_INTERFACE_ROOM + QLatin1String(".RoomName")))
23 {
24@@ -582,7 +588,7 @@
25 recipient = std::make_shared<messaging::Group>(
26 std::string{} /* no id exists yet */,
27 initial_invitees,
28- std::string{} /* group_title */);
29+ title);
30
31 std::shared_ptr<GroupStarter> group_starter = connection->group_starter();
32 messaging::Group::shared_ptr group = std::dynamic_pointer_cast<messaging::Group>(recipient);

Subscribers

People subscribed via source and target branches

to all changes: