Merge lp:~phablet-team/messaging-app/show-participants-mms-groups into lp:messaging-app/staging

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 624
Merged at revision: 625
Proposed branch: lp:~phablet-team/messaging-app/show-participants-mms-groups
Merge into: lp:messaging-app/staging
Diff against target: 11 lines (+0/-1)
1 file modified
src/qml/ThreadDelegate.qml (+0/-1)
To merge this branch: bzr merge lp:~phablet-team/messaging-app/show-participants-mms-groups
Reviewer Review Type Date Requested Status
Roberto Mier Escandon (community) Approve
Review via email: mp+310431@code.launchpad.net

Commit message

Show recipients instead of 'Group' on MMS groups.

Description of the change

Show recipients instead of 'Group' on MMS groups.

To post a comment you must log in.
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Into the conversation, is it correct having "Group (2)" as title?

review: Needs Information
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Ouch!
I see as group name the (first participant name + n additional participants in the group) for RCS groups once i get out and in of messaging-app

review: Needs Fixing
624. By Tiago Salem Herrmann

Fallback to participant names if no room name is provided

625. By Tiago Salem Herrmann

remove blank space

Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

works ferpectly

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/ThreadDelegate.qml'
2--- src/qml/ThreadDelegate.qml 2016-10-21 12:22:44 +0000
3+++ src/qml/ThreadDelegate.qml 2016-11-09 16:09:02 +0000
4@@ -46,7 +46,6 @@
5 } else if (chatRoomInfo.RoomName != "") {
6 return chatRoomInfo.RoomName
7 }
8- return i18n.tr("Group")
9 }
10 var firstRecipient
11 if (unknownContact) {

Subscribers

People subscribed via source and target branches

to all changes: