Merge lp:~phablet-team/messaging-app/fix-attachments-preview into lp:messaging-app/stable

Proposed by Tiago Salem Herrmann on 2017-01-09
Status: Merged
Approved by: Gustavo Pichorim Boiko on 2017-01-11
Approved revision: 617
Merged at revision: 617
Proposed branch: lp:~phablet-team/messaging-app/fix-attachments-preview
Merge into: lp:messaging-app/stable
Prerequisite: lp:~phablet-team/messaging-app/fix-argument-parsing2
Diff against target: 23 lines (+8/-5)
1 file modified
src/qml/MessageDelegate.qml (+8/-5)
To merge this branch: bzr merge lp:~phablet-team/messaging-app/fix-attachments-preview
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) 2017-01-09 Approve on 2017-01-11
Review via email: mp+314326@code.launchpad.net

Commit message

Fix attachments previewer.

Description of the change

Fix attachments previewer.

To post a comment you must log in.
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/MessageDelegate.qml'
2--- src/qml/MessageDelegate.qml 2016-11-18 21:15:46 +0000
3+++ src/qml/MessageDelegate.qml 2017-01-09 13:46:27 +0000
4@@ -188,11 +188,14 @@
5 }
6 highlightColor: "transparent"
7
8- onClicked: {
9- if (!selectMode) {
10- // we only have actions for attachment items, so forward the click
11- if (attachmentsLoader.item) {
12- attachmentsLoader.item.clicked(mouse)
13+ MouseArea {
14+ anchors.fill: parent
15+ onClicked: {
16+ if (!selectMode) {
17+ // we only have actions for attachment items, so forward the click
18+ if (attachmentsLoader.item) {
19+ attachmentsLoader.item.clicked(mouse)
20+ }
21 }
22 }
23 }

Subscribers

People subscribed via source and target branches

to all changes: