Merge lp:~phablet-team/mediaplayer-app/snap-it-up into lp:mediaplayer-app

[Jim Hodapp]

Initial snapping up of mediaplayer-app.

Initial snapping up of mediaplayer-app.

[lp:~phablet-team/mediaplayer-app/snap-it-up]

420. By Jim Hodapp on 2016-09-07

Add Snappy package revision number

[Scott Sweeny (ssweeny)]

Have you looked at what the snap contains and whether you can pare it down at all?

review: Needs Information

[Jim Hodapp (jhodapp)]

I haven't explicitly yet but I plan on doing that this afternoon on the media-hub one and this one.

[Scott Sweeny (ssweeny)]

`snapcraft cleanbuild` fails with:

cmake /root/parts/mediaplayer-app/src -DCMAKE_INSTALL_PREFIX= -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_LIBRARY_PATH=/usr/lib
-- The C compiler identification is unknown
-- The CXX compiler identification is unknown
CMake Error at CMakeLists.txt:1 (project):
  No CMAKE_C_COMPILER could be found.

  Tell CMake where to find the compiler by setting either the environment
  variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
  the compiler, or to the compiler name if it is in the PATH.

CMake Error at CMakeLists.txt:1 (project):
  No CMAKE_CXX_COMPILER could be found.

  Tell CMake where to find the compiler by setting either the environment
  variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
  to the compiler, or to the compiler name if it is in the PATH.

-- Configuring incomplete, errors occurred!
See also "/root/parts/mediaplayer-app/build/CMakeFiles/CMakeOutput.log".
See also "/root/parts/mediaplayer-app/build/CMakeFiles/CMakeError.log".
Command '['/bin/sh', '/tmp/tmp0xjubywb', 'cmake', '/root/parts/mediaplayer-app/src', '-DCMAKE_INSTALL_PREFIX=', '-DCMAKE_INSTALL_PREFIX:PATH=/usr', '-DCMAKE_LIBRARY_PATH=/usr/lib']' returned non-zero exit status 1
Command '['lxc', 'exec', 'snapcraft-slowly-happy-sponge', '--', 'snapcraft', 'snap', '--output', 'mediaplayer-app_0.20.5-1_amd64.snap']' returned non-zero exit status 1

I've solved this in my snaps by adding `build-essential` to `build-packages` but you could probably get away with just explicitly adding g++ or equivalent.

review: Needs Fixing

[lp:~phablet-team/mediaplayer-app/snap-it-up]

421. By Jim Hodapp on 2016-09-07

Make sure to pass snapcraft cleanbuild

[Jim Hodapp (jhodapp)]

Ok fixed this and it cleanly builds on Launchpad now.

[Scott Sweeny (ssweeny)]

This builds cleanly for me now too.

The resulting snap is 60MB on amd64 and a quick poke inside shows plenty of potential for cleanup :)

review: Needs Fixing

[lp:~phablet-team/mediaplayer-app/snap-it-up]

422. By Jim Hodapp on 2016-09-08

Shrink the size of the resulting snap package

423. By Jim Hodapp on 2016-09-08

Make sure the copyright file gets put in place

424. By Jim Hodapp on 2016-09-08

Shrink down the package even further

[Scott Sweeny (ssweeny)]

This is a pretty good start.

review: Approve

[Arthur Mello (artmello)]

lgtm

review: Approve

[lp:~phablet-team/mediaplayer-app/snap-it-up]

425. By Jim Hodapp on 2016-09-22

Merge with upstream

=== added file 'mediaplayer-app.wrapper'
--- mediaplayer-app.wrapper	1970-01-01 00:00:00 +0000
+++ mediaplayer-app.wrapper	2016-09-22 17:42:37 +0000
@@ -0,0 +1,23 @@
+#!/bin/bash
+
+if [ "$SNAP_ARCH" == "amd64" ]; then
+    ARCH="x86_64-linux-gnu"
+elif [ "$SNAP_ARCH" == "armhf" ]; then
+    ARCH="arm-linux-gnueabihf"
+else
+    ARCH="$SNAP_ARCH-linux-gnu"
+fi
+
+export LD_LIBRARY_PATH=$SNAP/usr/lib/$ARCH:$LD_LIBRARY_PATH
+
+# Qt Libs
+export LD_LIBRARY_PATH=$SNAP/usr/lib/$ARCH/qt5/libs:$LD_LIBRARY_PATH
+
+# Qt Modules
+export QT_PLUGIN_PATH=$SNAP/usr/lib/$ARCH/qt5/plugins
+export QML2IMPORT_PATH=$SNAP/usr/share/mediaplayer-app/qml/
+export QML2_IMPORT_PATH=$QML2_IMPORT_PATH:$SNAP/usr/lib/$ARCH/qt5/qml/
+
+echo QT_PLUGIN_PATH=$QT_PLUGIN_PATH
+
+exec "$SNAP/usr/bin/mediaplayer-app" "$@"

=== added file 'snapcraft.yaml'
--- snapcraft.yaml	1970-01-01 00:00:00 +0000
+++ snapcraft.yaml	2016-09-22 17:42:37 +0000
@@ -0,0 +1,70 @@
+name: mediaplayer-app
+version: 0.20.5-1
+summary: QML-based media player
+description: |
+  A QML media player that can play audio/video sources.
+  Please find the source at:
+  https://code.launchpad.net/mediaplayer-app
+confinement: strict
+
+apps:
+  mediaplayer-app:
+    command: usr/bin/mediaplayer-app
+    plugs: [mpris]
+
+parts:
+  mediaplayer-app:
+    plugin: cmake
+    source: .
+
+    build-packages:
+      - build-essential
+      - debhelper
+      - dh-translations
+      - libgl1-mesa-dev
+      - pkg-config
+      - python3
+      - qtbase5-dev
+      - qtdeclarative5-dev
+      - qtmultimedia5-dev
+
+    configflags:
+      - -DCMAKE_INSTALL_PREFIX:PATH=/usr
+      - -DCMAKE_LIBRARY_PATH=/usr/lib
+
+    stage-packages:
+      - qtubuntu-media
+      - qtdeclarative5-ubuntu-content1
+
+    filesets:
+      unwanted:
+        # Files that we don't want/need in the final snap package
+        - -etc
+        - -usr/lib/debug
+        - -usr/lib/*/libclick*
+        - -usr/lib/*/libhybris*
+        - -usr/lib/*/libogg*
+        - -usr/lib/*/libpulse*
+        - -usr/lib/python*
+        - -usr/share/apport
+        - -usr/share/bug
+        - -usr/share/doc
+        - -usr/share/fonts
+        - -usr/share/libwacom
+        - -usr/share/lintian
+        - -usr/share/man
+        - -usr/share/X11
+        - -usr/lib/*.a
+        - -usr/lib/*/*.a
+        - -usr/lib/*.la
+        - -usr/lib/*/*.la
+        - -usr/lib/*/*.o
+
+    snap:
+      - $unwanted
+
+  environment:
+    plugin: copy
+    files:
+      mediaplayer-app.wrapper: bin/mediaplayer-app
+      debian/copyright: usr/share/doc/mediaplayer-app/copyright