lp:~phablet-team/media-hub/fix-1596329
Created by
Jim Hodapp
and last modified
- Get this branch:
- bzr branch lp:~phablet-team/media-hub/fix-1596329
Members of
Ubuntu Phablet Team
can upload to this branch. Log in for directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Scott Sweeny (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 211 lines (+76/-30)7 files modifiedsrc/core/media/engine.h (+1/-1)
src/core/media/gstreamer/engine.cpp (+2/-2)
src/core/media/gstreamer/engine.h (+2/-1)
src/core/media/gstreamer/playbin.cpp (+49/-19)
src/core/media/gstreamer/playbin.h (+7/-3)
src/core/media/metadata.cpp (+13/-3)
src/core/media/player_implementation.cpp (+2/-1)
Related bugs
Bug #1596329: media-hub gets easily confused and hangs (needs reboot) | Critical | Fix Released |
|
Related blueprints
Branch information
Recent revisions
- 199. By Jim Hodapp
-
Further refine the fix so that the unit tests pass and we still don't get a deadlock
- 198. By Jim Hodapp
-
Only use the main thread context set_state_and_wait for stop(). Also re-enable the disabled unit test.
- 196. By Jim Hodapp
-
To avoid deadlocking, make sure that we don't ever change the pipeline's state on the streaming thread. It will always be set from the main thread context thanks to g_idle_add(). The deadlock that this fixes was when calling stop() in player_
implementation. cpp in the on_end_ of_tracklist( ) handler.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:media-hub