Merge lp:~phablet-team/media-hub/fix-1538703 into lp:media-hub
Proposed by
Konrad Zapałowicz
Status: | Approved |
---|---|
Approved by: | Alfonso Sanchez-Beato |
Approved revision: | 185 |
Proposed branch: | lp:~phablet-team/media-hub/fix-1538703 |
Merge into: | lp:media-hub |
Diff against target: |
322 lines (+125/-17) 9 files modified
debian/libmedia-hub-doc.install (+1/-1) doc/CMakeLists.txt (+2/-2) include/core/media/service.h (+0/-3) src/core/media/player_configuration.h (+3/-0) src/core/media/player_implementation.cpp (+68/-6) src/core/media/player_skeleton.h (+2/-0) src/core/media/service_implementation.cpp (+3/-3) src/core/media/service_skeleton.cpp (+35/-2) src/core/media/service_skeleton.h (+11/-0) |
To merge this branch: | bzr merge lp:~phablet-team/media-hub/fix-1538703 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alfonso Sanchez-Beato | Approve | ||
Review via email: mp+292038@code.launchpad.net |
This proposal supersedes a proposal from 2016-04-12.
Commit message
A rewrite of how the current player is set which is what the MPRIS control interface actively uses.
Description of the change
A rewrite of how the current player is set which is what the MPRIS control interface actively uses.
To post a comment you must log in.
Unmerged revisions
- 186. By Jim Hodapp
-
Pass a Service* instead of ServiceSkeleton* to avoid weird inheritance segfault
Looks good, but maybe we need to call update_ current_ player( ) also when adding complete track lists? Which is done with AddTrack(s) DBus calls.