lp:~phablet-team/media-hub/fix-1449790

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:media-hub at revision 170

Alfonso Sanchez-Beato: Approve on 2016-02-22

PS Jenkins bot: Approve (continuous-integration) on 2016-02-12

Diff: 780 lines (+429/-67)

13 files modified

include/core/media/player.h (+5/-0)
src/core/media/gstreamer/engine.cpp (+6/-3)
src/core/media/gstreamer/playbin.cpp (+129/-28)
src/core/media/gstreamer/playbin.h (+3/-0)
src/core/media/mpris/player.h (+8/-0)
src/core/media/player.cpp (+6/-0)
src/core/media/player_implementation.cpp (+2/-2)
src/core/media/player_skeleton.cpp (+57/-22)
src/core/media/player_stub.cpp (+2/-0)
src/core/media/track_list_implementation.cpp (+0/-1)
src/core/media/track_list_skeleton.cpp (+46/-11)
src/core/media/track_list_stub.cpp (+5/-0)
src/core/media/util/uri_check.h (+160/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1449790: Fails to play a file with a # (hash symbol) in the path

High

Fix Released

Link a bug report

Related blueprints

177. By Jim Hodapp on 2016-02-22

Removed no longer needed debug statement

176. By Jim Hodapp on 2016-02-22

Make sure to not crash during std::string::assign(gchar*)

175. By Jim Hodapp on 2016-02-22

One last comment addressed

174. By Jim Hodapp on 2016-02-22

Address review comments

173. By Jim Hodapp on 2016-02-22

Make sure other tracks can still be added to the tracklist after an invalid URI is determined. Also make sure to free all gchar strings

172. By Jim Hodapp on 2016-02-19

Get rid of some debug statements

171. By Jim Hodapp on 2016-02-19

Do the percent encoding and checking only from media-hub and don't involve qtubuntu-media

170. By Jim Hodapp on 2016-02-11

Make sure to interpret the incoming path as a URI which makes sure media-hub will always be able to open the track with an encoded URI

169. By CI Train Bot Account on 2016-01-27

Releasing 4.1.0+16.04.20160127-0ubuntu1

168. By Simon Fels on 2016-01-27

Don't depend on a specific hybris version anymore.