Merge lp:~phablet-team/history-service/include-message-when-group-cancelled into lp:history-service

Proposed by Roberto Mier Escandon
Status: Superseded
Proposed branch: lp:~phablet-team/history-service/include-message-when-group-cancelled
Merge into: lp:history-service
Prerequisite: lp:~phablet-team/history-service/group-chat
Diff against target: 27 lines (+16/-1)
1 file modified
daemon/historydaemon.cpp (+16/-1)
To merge this branch: bzr merge lp:~phablet-team/history-service/include-message-when-group-cancelled
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+304026@code.launchpad.net

This proposal has been superseded by a proposal from 2016-10-13.

Commit message

Trying to get in history daemon the event of group cancelled to insert a new event in related thread, to be seen in UI

Description of the change

Trying to get in history daemon the event of group cancelled to insert a new event in related thread, to be seen in UI

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:285
https://jenkins.canonical.com/system-apps/job/lp-history-service-ci/6/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1336/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1336
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1199
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1199
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1199
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1179
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1179/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1179
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1179/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1179/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1179
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1179/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1179
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1179/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1179
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1179/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1179
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1179/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1179
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1179/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1179/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-history-service-ci/6/rebuild

review: Needs Fixing (continuous-integration)
286. By Tiago Salem Herrmann

merge parent branch

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:286
https://jenkins.canonical.com/system-apps/job/lp-history-service-ci/7/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1341/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1341
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1204
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1204
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1204
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1184
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1184/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1184
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1184/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1184/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1184
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1184/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1184
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1184/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1184
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1184/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1184
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1184/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1184/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1184/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-history-service-ci/7/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

looks good. thanks.

review: Approve
287. By Tiago Salem Herrmann

merge parent branch

288. By Tiago Salem Herrmann

merge parent branch

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'daemon/historydaemon.cpp'
2--- daemon/historydaemon.cpp 2016-10-06 17:29:35 +0000
3+++ daemon/historydaemon.cpp 2016-10-06 17:29:36 +0000
4@@ -600,7 +600,22 @@
5
6 void HistoryDaemon::onUpdateRoomParticipants()
7 {
8- updateRoomParticipants(Tp::TextChannelPtr(qobject_cast<Tp::TextChannel*>(sender())));
9+ Tp::TextChannelPtr channel(qobject_cast<Tp::TextChannel*>(sender()));
10+
11+ // evaluate if removed self handle and insert an information message in the thread in that case
12+ if (channel->groupSelfContactRemoveInfo().isValid()) {
13+ QVariantMap properties = propertiesFromChannel(channel);
14+ QVariantMap thread = threadForProperties(channel->property(History::FieldAccountId).toString(),
15+ History::EventTypeText,
16+ properties,
17+ matchFlagsForChannel(channel),
18+ false);
19+ if (!thread.isEmpty()) {
20+ writeInformationEvent(thread, channel->groupSelfContactRemoveInfo().message());
21+ }
22+ }
23+
24+ updateRoomParticipants(channel);
25 }
26
27 void HistoryDaemon::updateRoomParticipants(const Tp::TextChannelPtr channel)

Subscribers

People subscribed via source and target branches

to all changes: