Merge lp:~phablet-team/gallery-app/fix-camera-launch into lp:gallery-app

Proposed by Bill Filler
Status: Needs review
Proposed branch: lp:~phablet-team/gallery-app/fix-camera-launch
Merge into: lp:gallery-app
Diff against target: 37 lines (+3/-3)
3 files modified
rc/qml/AlbumsOverview.qml (+1/-1)
rc/qml/EventsOverview.qml (+1/-1)
rc/qml/PhotosOverview.qml (+1/-1)
To merge this branch: bzr merge lp:~phablet-team/gallery-app/fix-camera-launch
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+312752@code.launchpad.net

Commit message

fix appId paths to launch camera-app correctly in snap environment

Description of the change

fix appId paths to launch camera-app correctly in snap environment

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:1344
https://jenkins.canonical.com/system-apps/job/lp-gallery-app-ci/32/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2150
    SUCCESS: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/552
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2153
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1981
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1981/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1981
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1981/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1981
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1981/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1981
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1981/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1981
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1981/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1981
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1981/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1981
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1981/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1981
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1981/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1981
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1981/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-gallery-app-ci/32/rebuild

review: Approve (continuous-integration)

Unmerged revisions

1344. By Bill Filler

fix appId paths to launch camera-app correctly in snap environment

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'rc/qml/AlbumsOverview.qml'
2--- rc/qml/AlbumsOverview.qml 2016-01-28 13:01:40 +0000
3+++ rc/qml/AlbumsOverview.qml 2016-12-07 21:51:05 +0000
4@@ -240,7 +240,7 @@
5 text: i18n.tr("Camera")
6 visible: !APP.desktopMode
7 iconName: "camera-app-symbolic"
8- onTriggered: Qt.openUrlExternally("appid://com.ubuntu.camera/camera/current-user-version")
9+ onTriggered: Qt.openUrlExternally("appid://camera-app/camera-app/current-user-version")
10 }
11 ]
12
13
14=== modified file 'rc/qml/EventsOverview.qml'
15--- rc/qml/EventsOverview.qml 2016-04-13 19:00:29 +0000
16+++ rc/qml/EventsOverview.qml 2016-12-07 21:51:05 +0000
17@@ -112,7 +112,7 @@
18 text: i18n.tr("Camera")
19 visible: !APP.desktopMode
20 iconName: "camera-app-symbolic"
21- onTriggered: Qt.openUrlExternally("appid://com.ubuntu.camera/camera/current-user-version")
22+ onTriggered: Qt.openUrlExternally("appid://camera-app/camera-app/current-user-version")
23 }
24 ]
25
26
27=== modified file 'rc/qml/PhotosOverview.qml'
28--- rc/qml/PhotosOverview.qml 2016-04-13 19:00:29 +0000
29+++ rc/qml/PhotosOverview.qml 2016-12-07 21:51:05 +0000
30@@ -138,7 +138,7 @@
31 text: i18n.tr("Camera")
32 visible: !APP.desktopMode
33 iconName: "camera-app-symbolic"
34- onTriggered: Qt.openUrlExternally("appid://com.ubuntu.camera/camera/current-user-version")
35+ onTriggered: Qt.openUrlExternally("appid://camera-app/camera-app/current-user-version")
36 }
37 ]
38

Subscribers

People subscribed via source and target branches

to all changes: