Merge lp:~phablet-team/dialer-app/fix_prefix_settings_saving into lp:dialer-app/staging

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 561
Merged at revision: 561
Proposed branch: lp:~phablet-team/dialer-app/fix_prefix_settings_saving
Merge into: lp:dialer-app/staging
Diff against target: 19 lines (+5/-5)
1 file modified
src/qml/SettingsPage/AccountSettings/SipNumberRewrite.qml (+5/-5)
To merge this branch: bzr merge lp:~phablet-team/dialer-app/fix_prefix_settings_saving
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
Review via email: mp+321995@code.launchpad.net

Commit message

Only try to assing previously set values if they are available.

Description of the change

Only try to assing previously set values if they are available.

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Looks good. thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/SettingsPage/AccountSettings/SipNumberRewrite.qml'
2--- src/qml/SettingsPage/AccountSettings/SipNumberRewrite.qml 2017-03-22 17:08:12 +0000
3+++ src/qml/SettingsPage/AccountSettings/SipNumberRewrite.qml 2017-04-05 13:45:43 +0000
4@@ -48,11 +48,11 @@
5 }
6
7 updating = true
8- numberRewriteSwitch.checked = props.numberRewrite
9- countryCodeField.text = props.defaultCountryCode
10- areaCodeField.text = props.defaultAreaCode
11- removeInputField.text = props.removeCharacters
12- prefixInputField.text = props.prefix
13+ numberRewriteSwitch.checked = props.numberRewrite ? props.numberRewrite : false
14+ countryCodeField.text = props.defaultCountryCode ? props.defaultCountryCode : ""
15+ areaCodeField.text = props.defaultAreaCode ? props.defaultAreaCode : ""
16+ removeInputField.text = props.removeCharacters ? props.removeCharacters : ""
17+ prefixInputField.text = props.prefix ? props.prefix : ""
18 updating = false
19 }
20

Subscribers

People subscribed via source and target branches

to all changes: