Merge ~pfsmorigo/ubuntu-cve-tracker:pfsmorigo/publish_cves_fix_esm-apps_status into ubuntu-cve-tracker:master
Proposed by
Paulo Flabiano Smorigo
Status: | Merged |
---|---|
Merged at revision: | 5267b30ee030f56105511b15830014b01e64b16f |
Proposed branch: | ~pfsmorigo/ubuntu-cve-tracker:pfsmorigo/publish_cves_fix_esm-apps_status |
Merge into: | ubuntu-cve-tracker:master |
Diff against target: |
88 lines (+57/-5) 3 files modified
scripts/publish-cves-to-website-api.py (+7/-5) test/website_api/use_esm_status_if_esm_release (+24/-0) test/website_api/use_esm_status_if_esm_release.json (+26/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alex Murray | Approve | ||
Review via email: mp+444054@code.launchpad.net |
Description of the change
I found a bug in the publish-cves scripts that ignored "released" status when it's esm-apps and the release is not EOL (focal on). The reason is that it was checking status == "released" but since status is a tuple the correct would be to check status[0] == "released".
I'm adding a test specifically for this case and planning to add more cases in the future.
Also, I took the opportunity to change the code a little bit in order to use in my future PR to add the pocket field.
Meanwhile, I'm checking all the CVEs we have esm-apps releases and will refresh the web page to fix the status.
To post a comment you must log in.
LGTM, thanks.