lp:~pfalcon/linaro-license-protection/revamp-buildinfo-tests

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~linaro-automation/linaro-license-protection/trunk at revision 163

Данило Шеган (community): Approve on 2013-02-20

Diff: 42 lines (+17/-5)

2 files modified

license_protected_downloads/tests/test_buildinfo.py (+16/-5)
license_protected_downloads/tests/testserver_root/build-info/no-build-info/file (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

163. By Paul Sokolovsky on 2013-02-20

Test separately for querying subdir access and access when no BUILD-INFO.txt.

Previous test_readFile_nonFile() was really confusing, there're two separate
cases to test for.

Also, make conclusions from previous wrong test patch due to presence of stray
BUILD-INFO.txt on local system: the real problem is not using actual dirs for
testdata, but trying to (ab)use source files directory as testdata: don't do
that, have each for its own purpose (source directory may contain arbitrary
files during development, but test corpus is just that).

162. By Paul Sokolovsky on 2013-02-20

Fix test_apply_to_dir: it is explicitly allowed to apply test to a dir.

BuildInfo class has code to handle that case.

161. By Paul Sokolovsky on 2013-02-20

Rename test_readFile_* -> test_apply_to_* to be up to date with semantics.

These tests no longer test just readFile() method, they test application
of BuildInfo class to a filesystem object. Also, if we test against
directory, call it such, and not "non-file", and add extra check that intended
name is indeed directory in the current dir.

160. By Paul Sokolovsky on 2013-02-20

Cleanup messages and make pep8 pass again.

159. By Paul Sokolovsky on 2013-02-15

Explicitly mention current version of the BUILD-INFO format.

And why do we have it at 0.1 still?

158. By Paul Sokolovsky on 2013-02-15

Confusing usage of "may" and "required", replace by "must".

According to source code.

157. By Georgy Redkozubov on 2013-01-30

[merge] Remove artifacts from upload dir

156. By Georgy Redkozubov on 2013-01-30

[merge] Added checks for empty BUILD-INFO.txt

155. By Georgy Redkozubov on 2013-01-29

[merge] Added check for BUILD-INFO.txt before publishing artifacts

154. By James Tunnicliffe on 2013-01-07

Merge in branch to create latest symlink for prebuilt job type