lp:~pfalcon/linaro-license-protection/openid-exception-for-internal-hosts

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~linaro-automation/linaro-license-protection/trunk at revision 168

Данило Шеган (community): Approve on 2013-02-21

Linaro Infrastructure: Pending requested 2013-02-21

Diff: 150 lines (+62/-26)

3 files modified

license_protected_downloads/tests/test_views.py (+25/-1)
license_protected_downloads/tests/testserver_root/build-info/origen-blob-openid.txt (+1/-0)
license_protected_downloads/views.py (+36/-25)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1112620: LAVA results don't show up for restricted builds

High

Fix Released

Link a bug report

Related blueprints

168. By Paul Sokolovsky on 2013-02-21

Handle API access check for INTERNAL_HOSTS early in file_server().

167. By Paul Sokolovsky on 2013-02-21

Add test data for test_exception_internal_host_for_lic_and_openid().

166. By Paul Sokolovsky on 2013-02-20

file_server(): Simplify if/else logic, avoid needless ladders.

165. By Paul Sokolovsky on 2013-02-20

Factor out function to send file for download (send_file()).

164. By Paul Sokolovsky on 2013-02-20

Testcases for files protected by OpenID still being accessible by INTERNAL_HOSTS

These tests fail so far due to bug in the app logic. On the critical path
to fix lp:1112620.

163. By Paul Sokolovsky on 2013-02-20

Test separately for querying subdir access and access when no BUILD-INFO.txt.

Previous test_readFile_nonFile() was really confusing, there're two separate
cases to test for.

Also, make conclusions from previous wrong test patch due to presence of stray
BUILD-INFO.txt on local system: the real problem is not using actual dirs for
testdata, but trying to (ab)use source files directory as testdata: don't do
that, have each for its own purpose (source directory may contain arbitrary
files during development, but test corpus is just that).

162. By Paul Sokolovsky on 2013-02-20

Fix test_apply_to_dir: it is explicitly allowed to apply test to a dir.

BuildInfo class has code to handle that case.

161. By Paul Sokolovsky on 2013-02-20

Rename test_readFile_* -> test_apply_to_* to be up to date with semantics.

These tests no longer test just readFile() method, they test application
of BuildInfo class to a filesystem object. Also, if we test against
directory, call it such, and not "non-file", and add extra check that intended
name is indeed directory in the current dir.

160. By Paul Sokolovsky on 2013-02-20

Cleanup messages and make pep8 pass again.

159. By Paul Sokolovsky on 2013-02-15

Explicitly mention current version of the BUILD-INFO format.

And why do we have it at 0.1 still?