Merge lp:~pfalcon/linaro-image-tools/readme-tests into lp:linaro-image-tools/11.11

[Paul Sokolovsky]

See commit message and associated bug.

[Loïc Minier (lool)]

On Mon, Aug 27, 2012, Paul Sokolovsky wrote:
> - - python-dbus
> + - python-dbus (and dbus, udisks)

dbus and udisks should be optional; python-dbus is required to check
whether dbus is running, and lit will try talking to udisks over dbus if
it's there, but if not it should continue gracefully.

> - - sfdisk
> + - sfdisk (from util-linux)

Hmm not sure how to capture this; we really want to list which commands
are needed for other distros, but under Debian or Ubuntu this is
guaranteed to be installed so doesn't beed to be listed.

> + python-argparse dpkg-dev python-parted dbus udisks python-dbus python-apt \

More than 79 chars?

--
Loïc Minier

[lp:~pfalcon/linaro-image-tools/readme-tests]

552. By Paul Sokolovsky on 2012-08-28

Wrap in 79 chars.

[Paul Sokolovsky (pfalcon)]

On Mon, 27 Aug 2012 15:25:23 -0000
Loïc Minier <email address hidden> wrote:

I should emphasize that this patch updates README section related only
to *test* (testsuite) dependencies, so should be looked at as such.

> On Mon, Aug 27, 2012, Paul Sokolovsky wrote:
> > - - python-dbus
> > + - python-dbus (and dbus, udisks)
>
> dbus and udisks should be optional; python-dbus is required to check
> whether dbus is running, and lit will try talking to udisks over dbus
> if it's there, but if not it should continue gracefully.

These are not optional *for testing*, their lack leads to testcases
failure, tested on ec2 instance (with server distro and thus lacking
dbus and friends by default).

>
> > - - sfdisk
> > + - sfdisk (from util-linux)
>
> Hmm not sure how to capture this; we really want to list which
> commands are needed for other distros, but under Debian or Ubuntu
> this is guaranteed to be installed so doesn't beed to be listed.

I wanted to get a single command line which you can run on supported
development system (ubuntu) and get all dependencies installed. There's
no such package as "sfdisk". And making a choice between concealing a
dependency and making apt-get report "already installed", I chose
latter ;-).

>
> > + python-argparse dpkg-dev python-parted dbus udisks
> > python-dbus python-apt \
>
> More than 79 chars?

Fixed.

--
Best Regards,
Paul

Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog

[lp:~pfalcon/linaro-image-tools/readme-tests]

553. By Paul Sokolovsky on 2012-08-28

Using ppa:linaro-maintainers/tools is still required on 12.04.

Using pristine packages leads to weird testr errors, see
https://bugs.launchpad.net/linaro-image-tools/+bug/1042208

[James Tunnicliffe (dooferlad)]

Thanks for tidying this up Paul. The README is nice and clear now.

review: Approve

[Loïc Minier (lool)]

On Tue, Aug 28, 2012, Paul Sokolovsky wrote:
> I should emphasize that this patch updates README section related only
> to *test* (testsuite) dependencies, so should be looked at as such.

ah right, indeed

--
Loïc Minier

=== modified file 'README'
--- README	2012-06-20 12:49:22 +0000
+++ README	2012-08-28 10:19:21 +0000
@@ -29,16 +29,29 @@
   - python-argparse
   - dpkg-dev
   - python-parted
-  - python-dbus
+  - python-dbus (and dbus, udisks)
   - python-apt
   - qemu-kvm
-  - sfdisk
+  - sfdisk (from util-linux)
   - apt-utils
+  - pep8
 
 Also consider installing pyflakes, which is optional but will enable more
 tests.
 
-And run the following command:
+Some of the packages above require fixes, which are as of Ubuntu 12.04 are
+not yet in upstream, so using Linaro PPA is required:
+
+  $ sudo add-apt-repository ppa:linaro-maintainers/tools
+
+Then, you can install all packages listed above in one go with the following
+command:
+
+  $ sudo apt-get install testrepository python-testtools python-debian \
+        python-argparse dpkg-dev python-parted dbus udisks python-dbus \
+        python-apt qemu-kvm util-linux apt-utils pep8 pyflakes
+
+To initialized testsuite, run the following command:
 
   $ testr init