Merge lp:~pfalcon/linaro-ci-dashboard/bzr_home into lp:linaro-ci-dashboard

Proposed by Paul Sokolovsky
Status: Merged
Approved by: Stevan Radaković
Approved revision: 58
Merged at revision: 61
Proposed branch: lp:~pfalcon/linaro-ci-dashboard/bzr_home
Merge into: lp:linaro-ci-dashboard
Diff against target: 35 lines (+6/-4)
1 file modified
dashboard/frontend/management/commands/jenkins.py (+6/-4)
To merge this branch: bzr merge lp:~pfalcon/linaro-ci-dashboard/bzr_home
Reviewer Review Type Date Requested Status
Stevan Radaković Approve
Review via email: mp+124919@code.launchpad.net

Description of the change

This is fixed for issues when checking out bzr branches in local Jenkins server we discussed few days ago in IRC. Commit message has more details.

To post a comment you must log in.
Revision history for this message
Stevan Radaković (stevanr) wrote :

Looks good.
Approve +1.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dashboard/frontend/management/commands/jenkins.py'
2--- dashboard/frontend/management/commands/jenkins.py 2012-09-12 11:50:06 +0000
3+++ dashboard/frontend/management/commands/jenkins.py 2012-09-18 13:23:21 +0000
4@@ -42,6 +42,7 @@
5 self.jenkins_user = settings.JENKINS_ADMIN_USER
6 self.jenkins_passwd = settings.JENKINS_ADMIN_PASSWD
7 self.jenkins_home = settings.JENKINS_HOME
8+ self.bzr_home = settings.JENKINS_HOME + "/bzr_home"
9 self.jenkins_log = settings.JENKINS_LOG_NAME
10 self.jenkins_war_url = settings.JENKINS_WAR_URL
11 self.jenkins_id = settings.JENKINS_DB_ID
12@@ -82,10 +83,10 @@
13 Installs/configure/start the jenkins making sure another
14 instance of jenkins is not running on the same self.port.
15 """
16+ # TODO: Install also OpenID and EC2 plugins
17 try:
18- # Download openid plugin
19- cmd = 'mkdir -p %s' % self.jenkins_home
20- self.run(cmd)
21+ self.run('mkdir -p %s' % self.jenkins_home)
22+ self.run('mkdir -p %s' % self.bzr_home)
23
24 # Stop any jenkins which is already running on the same port
25 cmd = "lsof -w -n -i tcp:%s | awk -F ' ' '{print $2}' | " \
26@@ -176,7 +177,8 @@
27 log_fn = os.path.join(self.jenkins_home, self.jenkins_log)
28 log_fd = open(log_fn, 'a')
29 ret = Popen(cmd, stdout=log_fd, stderr=STDOUT,
30- env={"JENKINS_HOME": self.jenkins_home})
31+ env={"JENKINS_HOME": self.jenkins_home,
32+ "BZR_HOME": self.bzr_home})
33
34 if ret.returncode:
35 raise CalledProcessError(1, cmd, 'cmd Failed')

Subscribers

People subscribed via source and target branches