Merge lp:~pfalcon/linaro-aws-tools/idle-bump into lp:linaro-aws-tools

Proposed by Paul Sokolovsky
Status: Merged
Approved by: Stevan Radaković
Approved revision: 91
Merged at revision: 96
Proposed branch: lp:~pfalcon/linaro-aws-tools/idle-bump
Merge into: lp:linaro-aws-tools
Diff against target: 12 lines (+1/-1)
1 file modified
monitor_ec2_build_slaves.py (+1/-1)
To merge this branch: bzr merge lp:~pfalcon/linaro-aws-tools/idle-bump
Reviewer Review Type Date Requested Status
Stevan Radaković code Approve
Review via email: mp+113367@code.launchpad.net

Description of the change

Bump idle instance reporting threshold to minimize false positives, while still monitoring this condition.

To post a comment you must log in.
Revision history for this message
Stevan Radaković (stevanr) wrote :

Approved. Looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'monitor_ec2_build_slaves.py'
2--- monitor_ec2_build_slaves.py 2012-07-04 05:07:03 +0000
3+++ monitor_ec2_build_slaves.py 2012-07-04 11:02:35 +0000
4@@ -32,7 +32,7 @@
5 # Is slave is idle (no current builds), warn if it ran for this time
6 # NOTE: this will lead to false positives. Generally, this is a problem
7 # if slave stays idle for more than 30 mins
8-INSTANCE_RUN_TIME_IDLE = 8 * HOUR
9+INSTANCE_RUN_TIME_IDLE = 15 * HOUR
10 # Unconditionally warn about instance running for so much
11 INSTANCE_RUN_TIME_TOO_LONG = 11 * HOUR
12 # Warn about builds running more than this

Subscribers

People subscribed via source and target branches