Merge lp:~pfalcon/linaro-android-mirror/xmlrpc-error-msg into lp:linaro-android-mirror
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Paul Sokolovsky | ||||
Approved revision: | 44 | ||||
Merged at revision: | 43 | ||||
Proposed branch: | lp:~pfalcon/linaro-android-mirror/xmlrpc-error-msg | ||||
Merge into: | lp:linaro-android-mirror | ||||
Diff against target: |
81 lines (+48/-1) 4 files modified
linaro_android_mirror/service.py (+17/-1) linaro_android_mirror/tests/data/manifest-bad-loc.xml (+5/-0) linaro_android_mirror/tests/data/manifest-no-rev.xml (+5/-0) linaro_android_mirror/tests/test_mirrorer_integrational.py (+21/-0) |
||||
To merge this branch: | bzr merge lp:~pfalcon/linaro-android-mirror/xmlrpc-error-msg | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Hudson-Doyle | Pending | ||
Review via email: mp+61739@code.launchpad.net |
Description of the change
Hello Michael,
Here's patch to actually report any exception happened during mirroring down to client, because so far client receive generic error, e.g. https:/
It also shows kind of issues I have with Twisted - it has strange defaults (not passing error content down to client), and to work that around, one have to dig in internal classes. Or maybe chain error callback thru the web of code, but that's exactly why exceptions were invented - to avoid that. Anyway, I based this solution on discussion at and around http://
Thanks,
Paul
I think the approach in lp:~mwhudson/linaro-android-mirror/xmlrpc-error-msg is a bit cleaner. I agree that DeferredList and XMLRPC error reporting are both pretty awkward though.