Merge lp:~pfalcon/linaro-android-frontend/snapshots-dl-area into lp:linaro-android-frontend

Proposed by Paul Sokolovsky
Status: Merged
Merged at revision: 239
Proposed branch: lp:~pfalcon/linaro-android-frontend/snapshots-dl-area
Merge into: lp:linaro-android-frontend
Diff against target: 34 lines (+8/-8)
1 file modified
static/buildDetails.js (+8/-8)
To merge this branch: bzr merge lp:~pfalcon/linaro-android-frontend/snapshots-dl-area
Reviewer Review Type Date Requested Status
Данило Шеган Pending
Review via email: mp+86080@code.launchpad.net

Description of the change

Well, frontend had a logic to not show any d/l links if there're no artifacts, get around that, because now our builds won't have any artifact info in Jenkins metadata.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'static/buildDetails.js'
2--- static/buildDetails.js 2011-12-16 14:32:00 +0000
3+++ static/buildDetails.js 2011-12-16 16:42:27 +0000
4@@ -160,12 +160,12 @@
5 return 'none found';
6 },
7 output: function (results) {
8+ var downloadAreaUrl = 'http://snapshots.linaro.org/android/' + rawBuildName + '/' + results.number.toString() + '/';
9+ Y.one('#all-output a').setAttribute(
10+ 'href', downloadAreaUrl);
11+ Y.one('#all-output a').removeClass('hidden');
12+ Y.one('#all-output span').addClass('hidden');
13 if (results.artifacts.length) {
14- var downloadAreaUrl = 'http://snapshots.linaro.org/android/' + rawBuildName + '/' + results.number.toString() + '/';
15- Y.one('#all-output a').setAttribute(
16- 'href', downloadAreaUrl);
17- Y.one('#all-output a').removeClass('hidden');
18- Y.one('#all-output span').addClass('hidden');
19 var downloadUrl = 'http://' + window.location.hostname + '/builds/' + rawBuildName + '/' + results.number.toString() + '/';
20 var listNode = Y.Node.create('<ul/>');
21 for (var i = 0; i < results.artifacts.length; i++) {
22@@ -178,9 +178,9 @@
23 }
24 return listNode;
25 } else {
26- Y.one('#all-output a').addClass('hidden');
27- Y.one('#all-output span').removeClass('hidden');
28- return Y.Node.create("<p>No output</p>");
29+// Y.one('#all-output a').addClass('hidden');
30+// Y.one('#all-output span').removeClass('hidden');
31+ return Y.Node.create("<p>Build artifacts not known</p>");
32 }
33 }
34 };

Subscribers

People subscribed via source and target branches