Merge lp:~pfalcon/linaro-android-frontend/more-logs into lp:linaro-android-frontend

Proposed by Paul Sokolovsky
Status: Merged
Merged at revision: 236
Proposed branch: lp:~pfalcon/linaro-android-frontend/more-logs
Merge into: lp:linaro-android-frontend
Diff against target: 14 lines (+2/-2)
1 file modified
static/buildDetails.js (+2/-2)
To merge this branch: bzr merge lp:~pfalcon/linaro-android-frontend/more-logs
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle (community) Approve
Review via email: mp+80373@code.launchpad.net

Description of the change

Raw, big, unwrapped build log linked currently from frontend is hardly the best choice - actually, it's suitable only for downloading, not online browsing. On the other hand, default Jenkins log is pretty useful, and some time ago we added Log Parser's parsed log. So, show links to all 3.

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Seems fine.

I have a branch that adds live console output to the build page but there's no way to find out how large a build log is without downloading all of it :(

review: Approve
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

On Tue, 25 Oct 2011 22:36:23 -0000
Michael Hudson-Doyle <email address hidden> wrote:

> Review: Approve
>
> Seems fine.
>
> I have a branch that adds live console output to the build page but
> there's no way to find out how large a build log is without
> downloading all of it :(

Yep, I remember you told about this. I also wonder if it's scalable to
try do duplicate all Jenkins features in frontend. We're using more and
more its features, and I hope we're past indecisiveness stage regarding
Jenkins, so hopefully we don't want to "hide" it with frontend, just
use fronted as a simplified "dashboard" instead, forwarding users
directly to Jenkins for more advanced info...

--
Best Regards,
Paul

Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

On Wed, 26 Oct 2011 15:37:29 -0000, Paul Sokolovsky <email address hidden> wrote:
> On Tue, 25 Oct 2011 22:36:23 -0000
> Michael Hudson-Doyle <email address hidden> wrote:
>
> > Review: Approve
> >
> > Seems fine.
> >
> > I have a branch that adds live console output to the build page but
> > there's no way to find out how large a build log is without
> > downloading all of it :(
>
> Yep, I remember you told about this. I also wonder if it's scalable to
> try do duplicate all Jenkins features in frontend. We're using more and
> more its features, and I hope we're past indecisiveness stage regarding
> Jenkins, so hopefully we don't want to "hide" it with frontend, just
> use fronted as a simplified "dashboard" instead, forwarding users
> directly to Jenkins for more advanced info...

Yeah, that's also a fair point.

Cheers,
mwh

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'static/buildDetails.js'
2--- static/buildDetails.js 2011-10-21 04:04:22 +0000
3+++ static/buildDetails.js 2011-10-25 19:06:25 +0000
4@@ -140,8 +140,8 @@
5 }
6 },
7 loglink: function (results) {
8- return Y.Node.create('<a>complete output</a>').setAttribute(
9- 'href', results.buildUrl + '/consoleText');
10+ return '<a href="' + results.buildUrl + '/parsed_console">Parsed</a> - <a href="'
11+ + results.buildUrl + '/console">Tail</a> - <a href="' + results.buildUrl + '/consoleText">Raw</a>';
12 },
13 testresults: function (results) {
14 if (results.artifacts.length) {

Subscribers

People subscribed via source and target branches