Merge lp:~pfalcon/linaro-android-frontend/http-downloads into lp:linaro-android-frontend

[Paul Sokolovsky]

Use HTTP download links for artifacts in frontend, following introduction of HTTP downloads on android-build. Benefits: faster downloads, less system load, shorter links, no need for extra options to wget to workaround SSL cert issues.

[Michael Hudson-Doyle (mwhudson)]

Looks OK to me, but I haven't tested it at all.

review: Approve

[Yongqin Liu (liuyq0307)]

Could you also modify post-build-lava.py to make the lava also use http to download?
I guess something like "build_url.replace('https', 'http')" would be ok.

review: Needs Fixing

[Paul Sokolovsky (pfalcon)]

> Looks OK to me, but I haven't tested it at all.

I tested it on a sandbox.

[Paul Sokolovsky (pfalcon)]

> Could you also modify post-build-lava.py to make the lava also use http to
> download?
> I guess something like "build_url.replace('https', 'http')" would be ok.

Yes, but that would be a separate patch ;-). Please feel free to provide one, or I will get to that some time later. And well, I wouldn't like to haste with changing all stuff immediately - for risk management, in case some issue with HTTP downloads will arise.

[Yongqin Liu (liuyq0307)]

OK, I see. Thanks.

for the post-build-lava.py one, i am thinking another modification for that file, maybe i can do that together.:)

review: Approve

=== modified file 'android_build/templates/buildDetails.html'
--- android_build/templates/buildDetails.html	2011-08-23 03:07:25 +0000
+++ android_build/templates/buildDetails.html	2011-10-25 18:09:39 +0000
@@ -76,7 +76,7 @@
         </p>
       </dd>
       <dt id="all-output">
-        <a href="/builds/{{buildName}}/output/">Output</a>
+        <a href="/builds/{{buildName}}/output/">Downloads</a>
         <span class="hidden">Output</span>
       </dt>
       <dd id="output">

=== modified file 'static/buildDetails.js'
--- static/buildDetails.js	2011-10-21 04:04:22 +0000
+++ static/buildDetails.js	2011-10-25 18:09:39 +0000
@@ -161,8 +161,9 @@
       },
       output: function (results) {
         if (results.artifacts.length) {
+          var downloadUrl = 'http://' + window.location.hostname + '/builds/' + rawBuildName + '/' + results.number.toString() + '/';
           Y.one('#all-output a').setAttribute(
-            'href', results.number.toString() + '/output/');
+            'href', downloadUrl);
           Y.one('#all-output a').removeClass('hidden');
           Y.one('#all-output span').addClass('hidden');
           var listNode = Y.Node.create('<ul/>');
@@ -170,7 +171,8 @@
             var artifact = results.artifacts[i];
             var itemNode = Y.Node.create('<li><a/></li>');
             itemNode.one('a').setContent(artifact.displayPath);
-            itemNode.one('a').setAttribute('href', results.buildUrl + '/artifact/' + artifact.relativePath);
+            // Strip static '/build/out' from relativePath
+            itemNode.one('a').setAttribute('href', downloadUrl + artifact.relativePath.substring(10));
             listNode.appendChild(itemNode);
           }
           return listNode;