Merge lp:~pfalcon/linaro-android-frontend/fix-config-lookup into lp:linaro-android-frontend

Proposed by Paul Sokolovsky
Status: Merged
Merged at revision: 231
Proposed branch: lp:~pfalcon/linaro-android-frontend/fix-config-lookup
Merge into: lp:linaro-android-frontend
Diff against target: 28 lines (+10/-8)
1 file modified
static/buildDetails.js (+10/-8)
To merge this branch: bzr merge lp:~pfalcon/linaro-android-frontend/fix-config-lookup
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Michael Hudson-Doyle Pending
Review via email: mp+72407@code.launchpad.net

Description of the change

This fixes "???" displayed for config for some jobs in https://android-build.linaro.org frontend.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'static/buildDetails.js'
2--- static/buildDetails.js 2011-06-21 17:38:09 +0000
3+++ static/buildDetails.js 2011-08-22 11:12:25 +0000
4@@ -31,14 +31,16 @@
5 return results.result || "RUNNING";
6 },
7 configuration: function (results) {
8- if (results.actions[0].parameters) {
9- var params = results.actions[0].parameters;
10- for (var i = 0; i < params.length; i++) {
11- if (params[i].name == "CONFIG") {
12- try {
13- return Y.Base64.decode(params[i].value);
14- } catch (error) {
15- return 'Not Base64 encoded?';
16+ for (var i = 0; i < results.actions.length; i++) {
17+ if (results.actions[i].parameters) {
18+ var params = results.actions[i].parameters;
19+ for (var j = 0; j < params.length; j++) {
20+ if (params[j].name == "CONFIG") {
21+ try {
22+ return Y.Base64.decode(params[j].value);
23+ } catch (error) {
24+ return 'Not Base64 encoded?';
25+ }
26 }
27 }
28 }

Subscribers

People subscribed via source and target branches