Merge lp:~pfalcon/linaro-android-build-tools/git-configs into lp:linaro-android-build-tools

Proposed by Paul Sokolovsky
Status: Merged
Merged at revision: 413
Proposed branch: lp:~pfalcon/linaro-android-build-tools/git-configs
Merge into: lp:linaro-android-build-tools
Diff against target: 26 lines (+16/-0)
1 file modified
node/build (+16/-0)
To merge this branch: bzr merge lp:~pfalcon/linaro-android-build-tools/git-configs
Reviewer Review Type Date Requested Status
Georgy Redkozubov Approve
Linaro Infrastructure Pending
Review via email: mp+93405@code.launchpad.net

Description of the change

Changes to support build configs in git. Example build: https://android-build.linaro.org/builds/~pfalcon/git-build-config/

To post a comment you must log in.
Revision history for this message
Georgy Redkozubov (gesha) wrote :

Since we don't use /tmp/buildconf.$$ dir in other places it makes sense to remove it at the end.
Otherwise approved.

review: Approve
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Well, I generally find it useful to have complete state of the system available while system functions, that helps with analysis and debugging (and that's unalienable states of *normal* system lifecycle). I'd say that we could delete it here, it's a small thing - but there's dozen of similar cases in the code already. So, I'd better go for consistency and having entire snapshot of system's state present for the lifetime of the build being performed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'node/build'
2--- node/build 2012-02-07 23:43:01 +0000
3+++ node/build 2012-02-16 14:00:25 +0000
4@@ -71,6 +71,22 @@
5 eval "$CONFIGURATION"
6 set +a
7
8+if [ -n "$BUILD_CONFIG_REPO" ]; then
9+ echo "Fetching build config indirectly from git"
10+ save_dir=$PWD
11+ rm -rf /tmp/buildconf.$$
12+ mkdir -p /tmp/buildconf.$$
13+ cd /tmp/buildconf.$$
14+ git clone "$BUILD_CONFIG_REPO"
15+ cd *
16+ git checkout "$BUILD_CONFIG_BRANCH"
17+ CONFIGURATION=$(cat "$BUILD_CONFIG_FILENAME")
18+ cd $save_dir
19+ set -a
20+ eval $CONFIGURATION
21+ set +a
22+fi
23+
24 # Backward compatibility with SCRIPT_NAME
25 if [ -n "$SCRIPT_NAME" ]; then
26 BUILD_TYPE="$SCRIPT_NAME"

Subscribers

People subscribed via source and target branches