Merge lp:~pfalcon/linaro-android-build-tools/final-build-step into lp:linaro-android-build-tools

[Paul Sokolovsky]

This change is the next step towards resolving lp:940226 - provided migration script will allow to find a point in which regular lockups occur - either in SSH transfer step, or after user-defined build steps finish, somewhere in core Jenkins code.

[Данило Шеган (danilo)]

Paul, thanks for working on this. Is newline required before </command> like that?

[Deepti B. Kalakeri (deeptik)]

I have seen the same syntax in the jobs config generated by jenkins where the </command> is in the newline. Am not sure if changing it to be in the same line as <command> would make a difference or give any syntax problems. But, in general the changes looks good +1.

[Deepti B. Kalakeri (deeptik)]

I agree with Danilo, we can bring the </command> directive in the same line and it would work.

[Paul Sokolovsky (pfalcon)]

> Paul, thanks for working on this. Is newline required before </command> like that?

Well, I just copied that from actual Jenkins config, and yes, it's apparently encodes newline between commands. In this specific case it is trailing, so might be possible to fold, or maybe not, depends on how Jenkins interprets it.

[Deepti B. Kalakeri (deeptik)]

On Thu, Jun 14, 2012 at 3:35 PM, Paul Sokolovsky <<email address hidden>
> wrote:

> > Paul, thanks for working on this. Is newline required before </command>
> like that?
>
> Well, I just copied that from actual Jenkins config, and yes, it's
> apparently encodes newline between commands. In this specific case it is
> trailing, so might be possible to fold, or maybe not, depends on how
> Jenkins interprets it.
>

I have verified this and jenkins interprets it correctly even if </command>
is in the same line.

>
> --
>
> https://code.launchpad.net/~pfalcon/linaro-android-build-tools/final-build-step/+merge/109648<https://code.launchpad.net/%7Epfalcon/linaro-android-build-tools/final-build-step/+merge/109648>
> Your team Linaro Infrastructure is requested to review the proposed merge
> of lp:~pfalcon/linaro-android-build-tools/final-build-step into
> lp:linaro-android-build-tools.
>

--
Thanks and Regards,
Deepti

[Deepti B. Kalakeri (deeptik)]

As discussed with Paul on IRC, lets keep the default jenkins syntax.
Looks good +1.

=== renamed file 'utils/mangle-jobs/sftp-as-build-step.mangle' => 'utils/mangle-jobs/build-steps-set.mangle'
=== modified file 'utils/mangle-jobs/builders.xml'
--- utils/mangle-jobs/builders.xml	2012-05-17 12:14:23 +0000
+++ utils/mangle-jobs/builders.xml	2012-06-11 14:29:23 +0000
@@ -129,4 +129,8 @@
         </delegate>
       </delegate>
     </jenkins.plugins.publish__over__ssh.BapSshBuilderPlugin>
+    <hudson.tasks.Shell>
+      <command>echo &quot;Build finished&quot;
+</command>
+    </hudson.tasks.Shell>
   </builders>