Merge ~petermakowski/launchpad:feat-viewport-meta into launchpad:master
| Status: | Merged |
|---|---|
| Approved by: | Ines Almeida |
| Approved revision: | 70273ecf946476fa6db6d5ad9c8c0297479c84a9 |
| Merge reported by: | Otto Co-Pilot |
| Merged at revision: | not available |
| Proposed branch: | ~petermakowski/launchpad:feat-viewport-meta |
| Merge into: | launchpad:master |
| Diff against target: |
12 lines (+1/-0) 1 file modified
lib/lp/app/templates/root-index.pt (+1/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ines Almeida | Approve | ||
|
Review via email:
|
|||
Commit message
feat: set viewport to match device width
- add meta viewport tag
- set initial zoom level to 1
Description of the change
This merge proposal adds meta viewport tag with settings that make launchpad homepage mobile-friendly by ensuring it scales correctly on different devices.
- width=device-width: sets the width of the viewport to match the screen's width in device-independent pixels
- initial-scale=1: sets the initial zoom level when the page is first loaded
## QA Steps
- Open developer tools
- Using device toolbar view page in mobile device dimensions
- Verify that the content is stacked as needed and does not overflow, look at the screenshot attached for reference
## Screenshots
### Before
https:/
### After
https:/
---
Note: there are some spacing issues around the navigation bar on mobile, but this will be addressed separately.
It's not ideal that the "log in" section is so crammed with the logo; but between that and the page being readable in small screens, it's best that the page as a whole is readable.
Also for non-logged in users (which first time users of the platform will always be), it actually looks OK: https:/
We can address that in another MP, I think this is a nice improvement!
Thank you for the proposal!