Launchpad itself

Merge ~petermakowski/launchpad:update-description-font-size into launchpad:master

  1. Git
  2. lp:~petermakowski/launchpad
  3. update-description-font-size
  4. Merge into master
Proposed by Peter Makowski
Status: Merged
Approved by: Colin Watson
Approved revision: 6addd191bfffd3e75076f17cd51b9ac0bd18bca5
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~petermakowski/launchpad:update-description-font-size
Merge into: launchpad:master
Diff against target: 12 lines (+2/-0)
1 file modified
lib/canonical/launchpad/icing/style.css (+2/-0)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+444647@code.launchpad.net

Commit message

update description font-size

Description of the change

update description font-size to match body font size

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

It may be worth grepping for font-family - there are a few other places that look similar. But this change looks fine, and addresses the most glaring mismatch I've noticed. Thanks!

review: Approve
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Voting criteria not met
https://jenkins.ols.canonical.com/online-services/job/launchpad/3266/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/canonical/launchpad/icing/style.css b/lib/canonical/launchpad/icing/style.css
2index fcda434..125f723 100644
3--- a/lib/canonical/launchpad/icing/style.css
4+++ b/lib/canonical/launchpad/icing/style.css
5@@ -28,6 +28,8 @@
6 div#edit-description,
7 div#edit-commit_message {
8 font-family: "Ubuntu Mono variable", "Ubuntu Mono", Consolas, Monaco, Courier, monospace;
9+ font-size: 0.8rem;
10+ line-height: 1.2rem;
11 margin: 1em 0;
12 }
13

Subscribers

People subscribed via source and target branches

to status/vote changes: