~peter-sabaini/charm-sudo-pair:feature/add-pd-logging

Branch merges

Propose for merging

Rejected for merging into charm-sudo-pair:master

James Troup (community): Needs Fixing on 2021-08-20

Paul Goins: Approve on 2021-08-19

Tom Haddon: Abstain on 2021-06-22

BootStack Reviewers: Pending (mr tracking; do not claim) requested 2022-06-11

Giuseppe Petralia: Pending requested 2021-06-09

Diff: 297 lines (+143/-6)

10 files modified

src/actions/actions.py (+13/-0)
src/config.yaml (+8/-0)
src/files/pagerdutyevent.py (+68/-0)
src/lib/libsudopair.py (+33/-1)
src/reactive/sudo_pair.py (+4/-0)
src/templates/sudo_approve.tmpl (+5/-2)
src/templates/sudo_pair.pagerduty.tmpl (+6/-0)
src/tests/unit/conftest.py (+2/-1)
src/tests/unit/test_actions.py (+3/-1)
src/tests/unit/test_libsudopair.py (+1/-1)

api

Superseded for merging into ~sudo-pair-charmers/charm-sudo-pair:master

Giuseppe Petralia: Pending requested 2021-06-09

Paul Goins: Pending requested 2021-06-09

Diff: 1981 lines (+857/-382)

22 files modified

.gitignore (+24/-16)
Makefile (+60/-33)
dev/null (+0/-185)
interfaces/.empty (+0/-0)
layers/.empty (+0/-0)
src/README.md (+1/-1)
src/actions/actions.py (+19/-2)
src/actions/remove-sudopair (+1/-0)
src/config.yaml (+8/-0)
src/copyright (+16/-0)
src/files/pagerdutyevent.py (+68/-0)
src/lib/libsudopair.py (+237/-0)
src/metadata.yaml (+1/-1)
src/reactive/sudo_pair.py (+25/-10)
src/templates/sudo_approve.tmpl (+5/-2)
src/templates/sudo_pair.pagerduty.tmpl (+6/-0)
src/tests/functional/conftest.py (+51/-38)
src/tests/functional/test_deploy.py (+53/-66)
src/tests/unit/conftest.py (+11/-5)
src/tests/unit/test_actions.py (+23/-0)
src/tests/unit/test_libsudopair.py (+206/-0)
src/tox.ini (+42/-23)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

7b10f8a... by Peter Sabaini on 2021-12-28

Address review comments

3681b10... by Peter Sabaini on 2020-11-19

Pagerduty alerting, action logging

Ability to have pagerduty alerts triggered on auto-approve. Revamp
logging, add logging for remove-sudopair action. Use https proxy to
contact the PD events endpoint if set in model config.

0e31f83... by Alvaro Uria on 2020-10-19

Merge remote-tracking branch 'drew/copyright'

Reviewed-on: https://code.launchpad.net/~afreiberger/charm-sudo-pair/+git/charm-sudo-pair/+merge/392422
Reviewed-by: Alvaro Uria <email address hidden>

7628722... by Drew Freiberger on 2020-10-19

Update copyright to 2018-2020

24bbbb2... by Giuseppe Petralia on 2020-08-14

Add copyright Apache-2

7e3bae4... by Giuseppe Petralia on 2020-08-11

Update noqa comments to do a single check

625fd16... by Giuseppe Petralia on 2020-08-10

Fix flake8/black conflicts.

98e3587... by Giuseppe Petralia on 2020-08-10

Extra Linting completed for 20.08 charm release

224d950... by Giuseppe Petralia on 2020-08-10

Blackened repository to 88 lines

421e685... by Giuseppe Petralia on 2020-08-10

Imported standard Makefile and tox.ini and fixed up tests